Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify usage of Docker even on installation #256

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ascheman
Copy link
Contributor

@ascheman ascheman commented Jun 9, 2024

I would like to make it easier for Docker user to use Kantra.


The easiest way to get the latest exectutable is to get it from the latest container image.
The easiest way to get the latest (or a particular/older) executable is to get it from the respective container image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stop asking people to download the latest from the images since we are publishing the binaries directly to the releases page. So I like if you change this to:

The easiest way to get a particular/older executable is to get it from the respective container image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, but currently there is no release published (or I cannot see it) if I follow the link from the README, e.g., to https://github.com/konveyor/kantra/releases/tag/v0.4.0). Can find only sources (as tar.gz or zip) over there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, taking a deeper look, the binaries are missing exactly for v0.4.0 ;-).

Nevertheless, I was only changing the contents as they were. If the team decides to change their distribution policy, they perhaps should change the docs accordingly by themselves and not leave it to some poor contributor who tries to solve a problem with the current docs wrt. to Docker usage ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks... I just fixed the binaries not on the 0.4.0 release :)

Yeah no worries, I'll do the update myself. Was just leaving a comment for others to see as well.

Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sane to me, but I left one comment about stop pointing folks to download from the container for latest releases since we have started publishing the binaries

@dymurray dymurray merged commit 0a65ef4 into konveyor:main Jun 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants