✨ kantra support .net provider on windows #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djzager
force-pushed
the
dotnet-framework-provider
branch
2 times, most recently
from
dbf25ff to
08f3d10
Compare
djzager
force-pushed
the
dotnet-framework-provider
branch
from
08f3d10 to
24dfd19
Compare
eemcmullan
reviewed
Jun 20, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| port, err := freeport.GetFreePort() |
There was a problem hiding this comment.
This is probably finding a free port on the host network, instead of the container network. We had this issue with other providers, and decided to re-try the container run if it fails: https://github.com/konveyor/kantra/blob/main/cmd/analyze.go#L1111
It's obviously not the best way around this, but haven't yet found another solution.
pranavgaikwad
approved these changes
Jun 20, 2024
| @@ -48,13 +48,34 @@ var ( | |||
| AnalysisOutputMountPath = path.Join(OutputPath, "output.yaml") | |||
| DepsOutputMountPath = path.Join(OutputPath, "dependencies.yaml") | |||
| ProviderSettingsMountPath = path.Join(ConfigMountPath, "settings.json") | |||
| DotnetFrameworks = map[string]bool{ | |||
There was a problem hiding this comment.
lol I know right. I was trying to think of a better way to do this...I'm all ears.
eemcmullan
approved these changes
Jun 20, 2024
|
Apart from minor concern of provider validation comment, LGTM! Thanks! |
djzager
force-pushed
the
dotnet-framework-provider
branch
from
24dfd19 to
75ca2d4
Compare
Signed-off-by: David Zager <[email protected]>
djzager
force-pushed
the
dotnet-framework-provider
branch
from
2343ba5 to
4872c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a provider for analyzing .NET application in the cross-platform and windows-only scenarios described in konveyor/enhancements#179.
Hold for #259 , will rebase after that merges.
Fixes #254