Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handle custom rules for .net framework #316

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

djzager
Copy link
Member

@djzager djzager commented Aug 13, 2024

This addresses a bug where custom rules were not being passed correctly.

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit on how to remove the need for the escape character

cmd/analyze.go Outdated Show resolved Hide resolved
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: David Zager <[email protected]>
@djzager djzager added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch. label Aug 14, 2024
@djzager djzager merged commit 94882ff into konveyor:main Aug 14, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 14, 2024
* 🐛 Handle custom rules for .net framework

Signed-off-by: David Zager <[email protected]>

* simplify path

Signed-off-by: David Zager <[email protected]>

---------

Signed-off-by: David Zager <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
eemcmullan pushed a commit that referenced this pull request Aug 22, 2024
* 🐛 Handle custom rules for .net framework



* simplify path



---------

Signed-off-by: David Zager <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: David Zager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants