Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cleanup for interrupt #322

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

eemcmullan
Copy link
Collaborator

No description provided.

Signed-off-by: Emily McMullan <[email protected]>
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -181,6 +182,9 @@ func NewAnalyzeCmd(log logr.Logger) *cobra.Command {
if val, err := cmd.Flags().GetBool(noCleanupFlag); err == nil {
analyzeCmd.cleanup = !val
}
ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean! glad I learned this rather than what I was saying!

@eemcmullan eemcmullan added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch. label Aug 22, 2024
@eemcmullan eemcmullan merged commit 2b4caf5 into konveyor:main Aug 22, 2024
3 checks passed
@eemcmullan eemcmullan deleted the sig-handler branch August 27, 2024 15:51
eemcmullan added a commit that referenced this pull request Aug 28, 2024
* remove first prov container last

Signed-off-by: Emily McMullan <[email protected]>

* handle cleanup for interrupt

Signed-off-by: Emily McMullan <[email protected]>

* include more detailed container names

Signed-off-by: Emily McMullan <[email protected]>

* fix deps in static report bulk option

Signed-off-by: Emily McMullan <[email protected]>

---------

Signed-off-by: Emily McMullan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants