🐛 Handle missing containerless-deps #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing container-kantra-deps setup caused kantra analyze-bin command segfault. Adding check and error message to fail nicely. Related to: konveyor#338 Signed-off-by: Marek Aufart <[email protected]>
aufi
commented
Oct 2, 2024
dymurray
reviewed
Oct 2, 2024
cmd/analyze-bin.go
Outdated
| path := filepath.Join(b.homeKantraDir, RulesetsLocation) | ||
| path := filepath.Join(b.homeKantraDir, "rulesets") | ||
| if _, err := os.Stat(path); os.IsNotExist(err) { | ||
| b.log.Error(err, "cannot find ruleset, ensure containerless-kantra-deps are in place") |
There was a problem hiding this comment.
Lets change this to specifically mention that we can't find the rulesets directory. Then add validation for the other deps
There was a problem hiding this comment.
OK, will make this logic more specific and move most of it to the command validation function.
Signed-off-by: Marek Aufart <[email protected]>
aufi
commented
Oct 2, 2024
| requiredDirs := []string{b.homeKantraDir, filepath.Join(b.homeKantraDir, "rulesets"), filepath.Join(b.homeKantraDir, JavaBundlesLocation), filepath.Join(b.homeKantraDir, JDTLSBinLocation)} | ||
| for _, path := range requiredDirs { | ||
| if _, err := os.Stat(path); os.IsNotExist(err) { | ||
| b.log.Error(err, "cannot open required path, ensure that container-less dependencies are installed") |
There was a problem hiding this comment.
Example error messages for missing rulesets:
ERRO[0000] cannot open required path, ensure that container-less dependencies are installed error="stat /home/.../.kantra/rulesets: no such file or directory"
Signed-off-by: Marek Aufart <[email protected]>
eemcmullan
approved these changes
Oct 2, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing container-kantra-deps setup caused kantra analyze-bin command failure (details below). Appears when someone skips README step cloning and moving https://github.com/eemcmullan/containerless-kantra-deps.git to
~/.kantraAdding check and error message to fail nicely.
Related to: #338