Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config jvm max mem #361

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Config jvm max mem #361

merged 1 commit into from
Nov 4, 2024

Conversation

eemcmullan
Copy link
Collaborator

No description provided.

Signed-off-by: Emily McMullan <[email protected]>
@eemcmullan eemcmullan requested review from aufi and jmle October 28, 2024 15:50
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -828,6 +828,9 @@ func (a *analyzeCommand) getConfigVolumes() (map[string]string, error) {
}
javaConfig.InitConfig[0].ProviderSpecificConfig["mavenSettingsFile"] = fmt.Sprintf("%s/%s", ConfigMountPath, "settings.xml")
}
if Settings.JvmMaxMem != "" {
javaConfig.InitConfig[0].ProviderSpecificConfig["jvmMaxMem"] = Settings.JvmMaxMem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eemcmullan eemcmullan merged commit 6911c1a into konveyor:main Nov 4, 2024
3 checks passed
@eemcmullan eemcmullan deleted the jvm-mem branch November 13, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants