Fix relative paths, add CI test #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pranavgaikwad
commented
Aug 25, 2023
•
pranavgaikwad
commented
- add CI test
- create output dir if not exists
- handle relative paths correctly to --input / --output
- use temp dir in shim to avoid file exists error (happened when xmlrules already existed)
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
eemcmullan
approved these changes
Aug 25, 2023
| @@ -133,9 +134,16 @@ func (a *analyzeCommand) Validate() error { | |||
| } | |||
| stat, err := os.Stat(a.output) | |||
| if err != nil { | |||
| return fmt.Errorf("failed to stat output directory %s", a.output) | |||
| if errors.Is(err, os.ErrNotExist) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.