Validate mvn and openjdk & fix list providers for containerless mode #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
validate-reqs
branch
from
74cbf10
to
0b3a8f3
Compare
eemcmullan
changed the title
aufi
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Looks and works great!
Tested locally:
$ RUN_LOCAL=1 go run main.go analyze --list-providers
INFO[0000]
containerless analysis mode set; only java provider supported
$ RUN_LOCAL=1 go run main.go analyze -i /home/.../mig/workshop-migrate-jboss-on-app-service/ -o /tmp/nonbulk12 -t cloud-readiness
INFO[0000]
running analysis in containerless mode
ERRO[0000] failed to validate flags error="exec: \"mvn\": executable file not found in $PATH cannot find requirement maven; ensure maven is installed"
Error: exec: "mvn": executable file not found in $PATH cannot find requirement maven; ensure maven is installed
exit status 1
aufi
added
the
cherry-pick/release-0.6
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…374) validate mvn and openjdk Signed-off-by: Emily McMullan <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
eemcmullan
added a commit
that referenced
this pull request
Nov 14, 2024
…374) (#375) validate mvn and openjdk Signed-off-by: Emily McMullan <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Emily McMullan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://issues.redhat.com/browse/MTA-4160 & https://issues.redhat.com/browse/MTA-4218