Update containerless docs & reqs #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemcmullan
added
the
cherry-pick/release-0.6
eemcmullan
force-pushed
the
continerless-docs
branch
from
309dd41
to
218cfdf
Compare
aufi
approved these changes
Nov 25, 2024
cmd/analyze-bin.go
Outdated
| @@ -215,7 +215,12 @@ func (a *analyzeCommand) RunAnalysisContainerless(ctx context.Context) error { | |||
| } | |||
|
|
|||
| func (a *analyzeCommand) ValidateContainerless(ctx context.Context) error { | |||
| // validate mvn and openjdk install | |||
| // validate mvn, python, and openjdk install | |||
| _, pythonErr := exec.LookPath("python3") | |||
There was a problem hiding this comment.
Just note, python3 works on Fedora/RHEL, I cannot test Mac/Windows.
Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
force-pushed
the
continerless-docs
branch
from
218cfdf
to
bca2875
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
update containerless docs Signed-off-by: Emily McMullan <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
eemcmullan
added a commit
that referenced
this pull request
Nov 25, 2024
update containerless docs Signed-off-by: Emily McMullan <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Emily McMullan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.