Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands for windows #53

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

eemcmullan
Copy link
Collaborator

@eemcmullan eemcmullan commented Sep 6, 2023

Closes
#21
#54

cmd/container.go Outdated Show resolved Hide resolved
@pranavgaikwad
Copy link
Contributor

also, there were some changes in the rulesets that's causing CI to fail. we need to add two more labels on one of the rules that gets triggered. Here's a diff:

diff --git a/test-data/analysis-output.yaml b/test-data/analysis-output.yaml
index c9f0c89..7d24d64 100644
--- a/test-data/analysis-output.yaml
+++ b/test-data/analysis-output.yaml
@@ -137,6 +137,8 @@
       category: mandatory
       labels:
       - konveyor.io/target=cloud-readiness
+      - konveyor.io/target
+      - konveyor.io/source
       - discovery
       incidents:
       - uri: file:///opt/input/source/target/classes/persistence.properties

@eemcmullan eemcmullan force-pushed the windows-fix branch 2 times, most recently from 610349e to 0675ada Compare September 12, 2023 17:06
@pranavgaikwad pranavgaikwad merged commit aca5035 into konveyor:main Sep 12, 2023
1 check failed
@eemcmullan eemcmullan deleted the windows-fix branch January 23, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants