-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for replicateDeletionCallback #1077
test: add tests for replicateDeletionCallback #1077
Conversation
Thanks for making a pull request! 😃 |
@Prakhar-Agarwal-byte Seems like some automated test has failed. Can you please check and fix your code to address it. |
947b24c
to
3dcaa4d
Compare
Signed-off-by: prakharagarwal1 <[email protected]>
Signed-off-by: prakharagarwal1 <[email protected]>
Signed-off-by: prakharagarwal1 <[email protected]>
3dcaa4d
to
a654edc
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
+ Coverage 14.86% 14.92% +0.06%
==========================================
Files 86 86
Lines 8181 8181
==========================================
+ Hits 1216 1221 +5
+ Misses 6649 6641 -8
- Partials 316 319 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added test for replicateDeletionCallback in the filesystem package. These tests cover 2 cases
Fixes a part of #881