Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ reconcile issue reusable workflow #58

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

djzager
Copy link
Member

@djzager djzager commented Feb 1, 2024

Introduce a reusable workflow that can be used by Konveyor projects to:

  1. look for triage/accepted label. Adds needs-triage if missing.
  2. look for kind/ label. Add needs-kind if missing.
  3. look for priority/ label. Add needs-priority if missing.

When the event type is created/opened, then add it to the Planning board.

This PR also introduces a reusable workflow to handle issue comments. In much the same way the kube prow label plugin can handle /kind bug or /triage accepted commands (and their negatives /remove-kind bug or /remove-triage accepted), this workflow attempts to handle those commands that could be put in issue comments to make triaging a little more straightforward.

Fixes #57

@djzager
Copy link
Member Author

djzager commented Feb 1, 2024

uses: actions/github-script@v7
with:
script: |
// begin helper function for adding comments
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be a separate file? As inline YAML, it is harder to review the logic within it, because we lose syntax highlighting (which can make hard to maintain this in the future)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I think what I will do is create an issue to rewrite it in golang to expand those that can help us maintain/fix it when it breaks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll write the issue for that after this merges so I can link to the source lines where we have javascript as inline YAML.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Introduce a reusable workflow that can be used by Konveyor projects to:

1. look for `triage/accepted` label. Adds `needs-triage` if missing.
1. look for `kind/` label. Add `needs-kind` if missing.
1. look for `priority/` label. Add `needs-priority` if missing.

When the event type is created/opened, then add it to the Planning board.

Signed-off-by: David Zager <[email protected]>
@djzager djzager force-pushed the reconcile-issue-workflow branch from 5d80fd5 to 288e54f Compare February 2, 2024 21:20
Copy link
Member

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aufi
Copy link
Member

aufi commented Feb 5, 2024

👍

@djzager djzager merged commit 3467e0c into konveyor:main Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconcile GitHub Issues Workflow
4 participants