Skip to content

Commit

Permalink
[RFR] fix migration waves filter test and remove bug marks (#738)
Browse files Browse the repository at this point in the history 
Signed-off-by: Neilhamza <[email protected]>
  • Loading branch information
@Neilhamza
Neilhamza authored Oct 10, 2023
1 parent c4372d5 commit 42c4d9f
Show file tree
Hide file tree
Showing 10 changed files with 29 additions and 29 deletions.
2 changes: 1 addition & 1 deletion cypress/e2e/tests/migration/migration-waves/create_tracker.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe(["@tier1"], "Testing the creation of a tracker in migration waves", fun
application.create();
});

it("Bug MTA-1337: Verify create tracker button is visible", function () {
it("Verify create tracker button is visible", function () {
MigrationWave.open();

// create new migration wave
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/tests/migration/migration-waves/crud.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe(["@tier1"], "Migration Waves CRUD operations", () => {
});

// Automates Polarion TC 332
it("Bug MTA-1281, Bug MTA-1343: Migration Wave CRUD", function () {
it("Migration Wave CRUD", function () {
const migrationWave = new MigrationWave(
data.getRandomWord(8),
now,
Expand Down Expand Up @@ -104,7 +104,7 @@ describe(["@tier1"], "Migration Waves CRUD operations", () => {
});

// Automates Polarion TC 333
it("Bug MTA-1281, Bug MTA-1343: Migration Wave Application Association", function () {
it("Migration Wave Application Association", function () {
applications = createMultipleApplications(2);
const migrationWave = new MigrationWave(
data.getRandomWord(8),
Expand Down
8 changes: 4 additions & 4 deletions cypress/e2e/tests/migration/migration-waves/export_to_jira_cloud.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe(["@tier0", "@interop"], "Export Migration Wave to Jira Cloud", function
});

Object.values(JiraIssueTypes).forEach((issueType) => {
it(`Bug MTA-1281: Create wave to export as ${issueType}`, function () {
it(`Create wave to export as ${issueType}`, function () {
const apps = createMultipleApplications(2);
applications.push(...apps);

Expand All @@ -76,7 +76,7 @@ describe(["@tier0", "@interop"], "Export Migration Wave to Jira Cloud", function
});

Object.values(JiraIssueTypes).forEach((issueType) => {
it(`Bug MTA-1281: Export wave as ${issueType} to Jira`, function () {
it(`Export wave as ${issueType} to Jira`, function () {
jiraCloudInstance
.getProject(Cypress.env("jira_atlassian_cloud_project"))
.then((project) => {
Expand All @@ -100,7 +100,7 @@ describe(["@tier0", "@interop"], "Export Migration Wave to Jira Cloud", function
});

Object.values(JiraIssueTypes).forEach((issueType) => {
it(`Bug MTA-1281: Assert exports for ${issueType}`, function () {
it(`Assert exports for ${issueType}`, function () {
cy.wait(30 * SEC); // Enough time to create both tasks and for them to be available in the Jira API
jiraCloudInstance.getIssues(projectName).then((issues: JiraIssue[]) => {
const waveIssues = issues.filter((issue) => {
Expand All @@ -121,7 +121,7 @@ describe(["@tier0", "@interop"], "Export Migration Wave to Jira Cloud", function
});
});

after("Bug MTA-1281: Clear test data", function () {
after("Clear test data", function () {
Object.values(wavesMap).forEach((wave: MigrationWave) => wave.delete());
applications.forEach((app) => app.delete());
jiraCloudInstance.delete();
Expand Down
8 changes: 4 additions & 4 deletions cypress/e2e/tests/migration/migration-waves/export_to_jira_datacenter.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe(["@tier1"], "Export Migration Wave to Jira Datacenter", function () {
});

Object.values(JiraIssueTypes).forEach((issueType) => {
it(`Bug MTA-1281: Create wave to export as ${issueType}`, function () {
it(`Create wave to export as ${issueType}`, function () {
const apps = createMultipleApplications(2);
applications.push(...apps);

Expand All @@ -76,7 +76,7 @@ describe(["@tier1"], "Export Migration Wave to Jira Datacenter", function () {
});

Object.values(JiraIssueTypes).forEach((issueType) => {
it(`Bug MTA-1281: Export wave as ${issueType} to Jira`, function () {
it(`Export wave as ${issueType} to Jira`, function () {
jiraInstance
.getProjectById(Cypress.env("jira_stage_datacenter_project_id"))
.then((project) => {
Expand All @@ -100,7 +100,7 @@ describe(["@tier1"], "Export Migration Wave to Jira Datacenter", function () {
});

Object.values(JiraIssueTypes).forEach((issueType) => {
it(`Bug MTA-1281: Assert exports for ${issueType}`, function () {
it(`Assert exports for ${issueType}`, function () {
cy.wait(40 * SEC); // Enough time to create both tasks and for them to be available in the Jira API
jiraInstance.getIssues(projectName).then((issues: JiraIssue[]) => {
const waveIssues = issues.filter((issue) => {
Expand All @@ -121,7 +121,7 @@ describe(["@tier1"], "Export Migration Wave to Jira Datacenter", function () {
});
});

after("Bug MTA-1281: Clear test data", function () {
after("Clear test data", function () {
MigrationWave.open(true);
deleteByList(Object.values(wavesMap) as MigrationWave[]);
deleteByList(applications);
Expand Down
6 changes: 3 additions & 3 deletions cypress/e2e/tests/migration/migration-waves/field_validation.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe(["@tier1"], "Migration Waves Validations", () => {
migrationWave.create();
});

it("Bug MTA-1281: Name validations", function () {
it("Name validations", function () {
const invalidMessage = "Name is invalid. The name must be between 3 and 120 characters";
MigrationWave.openNewForm();
cy.get(commonView.submitButton).should("be.disabled");
Expand All @@ -61,7 +61,7 @@ describe(["@tier1"], "Migration Waves Validations", () => {
clickJs(cancelButton);
});

it("Bug MTA-1281: Dates Validations", function () {
it("Dates Validations", function () {
MigrationWave.openNewForm();
MigrationWave.fillName(data.getRandomWord(5));
cy.get(commonView.submitButton).should("be.disabled");
Expand Down Expand Up @@ -98,7 +98,7 @@ describe(["@tier1"], "Migration Waves Validations", () => {
cy.get(commonView.submitButton).should("be.enabled");
clickJs(cancelButton);
});
it("Bug MTA-1281: Duplicate Migration wave name validation", function () {
it("Duplicate Migration wave name validation", function () {
const migrationWavesList: MigrationWave[] = [];
const name = data.getRandomWord(8);
const { start: startDate, end: endDate } = generateRandomDateRange();
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/tests/migration/migration-waves/filter.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe(["@tier2"], "Migration waves filter validations", function () {
migrationWavesList = createMultipleMigrationWaves(2);
});

it("Bug MTA-1281: Name filter validations", function () {
it("Name filter validations", function () {
MigrationWave.open();

// Enter an existing display name substring and assert
Expand Down
8 changes: 4 additions & 4 deletions cypress/e2e/tests/migration/migration-waves/filter_applications.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe(
);
});

it("Bug MTA-1281: Filter applications by name", function () {
it("Filter applications by name", function () {
const migrationWave = new MigrationWave(
data.getRandomWord(8),
now,
Expand Down Expand Up @@ -94,7 +94,7 @@ describe(
migrationWave.delete();
});

it("Bug MTA-1281: Filter applications by business service", function () {
it("Filter applications by business service", function () {
const migrationWave = new MigrationWave(
data.getRandomWord(8),
now,
Expand Down Expand Up @@ -122,7 +122,7 @@ describe(
migrationWave.delete();
});

it("Bug MTA-1281: Filter applications by owner", function () {
it("Filter applications by owner", function () {
const migrationWave = new MigrationWave(
data.getRandomWord(8),
now,
Expand Down Expand Up @@ -150,7 +150,7 @@ describe(
migrationWave.delete();
});

after("Bug MTA-1281: Perform test data clean up", function () {
after("Perform test data clean up", function () {
deleteByList(applicationsList);
deleteByList(businessservicesList);
deleteByList(tagList);
Expand Down
8 changes: 4 additions & 4 deletions cypress/e2e/tests/migration/migration-waves/pagination.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe(["@tier3"], "Migration Waves pagination validations", function () {
migrationWavesList = createMultipleMigrationWaves(11);
});

it("Bug MTA-1281: Navigation button validations", function () {
it("Navigation button validations", function () {
MigrationWave.open();
selectItemsPerPage(10);

Expand Down Expand Up @@ -62,7 +62,7 @@ describe(["@tier3"], "Migration Waves pagination validations", function () {
cy.get(commonView.firstPageButton).should("not.be.disabled");
});

it("Bug MTA-1281: Items per page validations", function () {
it("Items per page validations", function () {
MigrationWave.open();

selectItemsPerPage(10);
Expand All @@ -84,7 +84,7 @@ describe(["@tier3"], "Migration Waves pagination validations", function () {
});
});

it("Bug MTA-1281: Page number validations", function () {
it("Page number validations", function () {
MigrationWave.open();
selectItemsPerPage(10);

Expand All @@ -97,7 +97,7 @@ describe(["@tier3"], "Migration Waves pagination validations", function () {
goToPage(1);
});

after("Bug MTA-1281: Perform test data clean up", function () {
after("Perform test data clean up", function () {
deleteByList(migrationWavesList);
});
});
8 changes: 4 additions & 4 deletions cypress/e2e/tests/migration/migration-waves/sort.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe(["@tier2"], "Migration Waves sort validations", function () {
businessServicesList = createMultipleBusinessServices(3);
});

it("Bug MTA-1281: Name sort validations", function () {
it("Name sort validations", function () {
MigrationWave.open();

const unsortedList = getTableColumnData(name);
Expand All @@ -76,7 +76,7 @@ describe(["@tier2"], "Migration Waves sort validations", function () {
verifySortDesc(afterDescSortList, unsortedList);
});

it("Bug MTA-1281: Start date sort validations", function () {
it("Start date sort validations", function () {
MigrationWave.open();

const unsortedList = getTableColumnData(startDate);
Expand All @@ -92,7 +92,7 @@ describe(["@tier2"], "Migration Waves sort validations", function () {
verifyDateSortDesc(afterDescSortList, unsortedList);
});

it("Bug MTA-1281: End date sort validations", function () {
it("End date sort validations", function () {
MigrationWave.open();

const unsortedList = getTableColumnData(endDate);
Expand All @@ -107,7 +107,7 @@ describe(["@tier2"], "Migration Waves sort validations", function () {
const afterDescSortList = getTableColumnData(endDate);
verifyDateSortDesc(afterDescSortList, unsortedList);
});
it("Bug MTA-1281: Sort Manage applications table", function () {
it("Sort Manage applications table", function () {
for (let i = 0; i < 3; i++) {
const appdata = {
name: data.getRandomWord(4),
Expand Down
4 changes: 2 additions & 2 deletions cypress/utils/utils.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,8 @@ export function selectFilter(filterName: string, identifiedRisk?: boolean, value
.eq(value)
.within(() => {
cy.get("#filtered-by").click();
cy.get('ul[aria-labelledby="filtered-by"]').within(() => {
clickByText("a", filterName);
cy.get("div.pf-v5-c-menu__content").within(() => {
clickByText("span", filterName);
});
});
}
Expand Down

0 comments on commit 42c4d9f

Please sign in to comment.