Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Update cypress version #1139

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[RFR] Update cypress version #1139

merged 1 commit into from
Jun 18, 2024

Conversation

mguetta1
Copy link
Contributor

No description provided.

@mguetta1 mguetta1 requested a review from sshveta June 18, 2024 10:21
abrugaro
abrugaro requested changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please upgrade the version in the Docker image as well to be consistent?

In dockerfiles/interop/Dockerfile change the first line to FROM docker.io/cypress/included:13.6.4

Thanks

package.json Outdated Show resolved Hide resolved
@mguetta1
Update cypress version
8441d28 
Signed-off-by: Maayan Hadasi <[email protected]>
@mguetta1 mguetta1 requested a review from abrugaro June 18, 2024 10:45
@mguetta1 mguetta1 changed the title Update cypress version [RFR] Update cypress version Jun 18, 2024
abrugaro
abrugaro approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguetta1 mguetta1 marked this pull request as draft June 18, 2024 14:33
@mguetta1
Copy link
Contributor Author

Converted to draft till I will have a successful run in Jenkins

@sshveta sshveta marked this pull request as ready for review June 18, 2024 17:24
@sshveta
Copy link
Collaborator

sshveta commented Jun 18, 2024

The old run did not progress.
Merging and triggering a run .

@sshveta sshveta merged commit 99560cd into konveyor:mta_6.2.0 Jun 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrugaro abrugaro abrugaro approved these changes

@sshveta sshveta sshveta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mguetta1 @sshveta @abrugaro