Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Test tasks tab in detail drawer #1242

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EstyBiton
Copy link

@EstyBiton EstyBiton commented Oct 15, 2024

Add Tests for Tasks Tab in Application Drawer ,The tests ensure that the Task Kind column accurately displays the expected task types after performing an analysis.
tasks kind:
Language Discovery
Tech Discovery
Analyzer
screenshot after test:
Screenshot from 2024-10-30 13-44-03

Copy link

openshift-ci bot commented Oct 15, 2024

Hi @EstyBiton. Thanks for your PR.

I'm waiting for a konveyor member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 15, 2024
@abrugaro
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2024
@abrugaro abrugaro self-requested a review October 15, 2024 15:23
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!! 😄

I left some minor improvements

@EstyBiton
Copy link
Author

Updated the code based on feedback. Thank you!

@EstyBiton EstyBiton requested a review from abrugaro October 26, 2024 21:25
@EstyBiton EstyBiton force-pushed the test-tasks-tab-in-detail-drawer branch from 020a59a to 67278fa Compare October 27, 2024 08:52
Signed-off-by: EstyBiton <[email protected]>
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😃

@mguetta1
Copy link
Contributor

@sshveta, @abrugaro please note that this PR should be merged after: konveyor/tackle2-ui#2123

@sshveta sshveta changed the title Test tasks tab in detail drawer [Draft] Test tasks tab in detail drawer Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants