Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Test of Add 'ActionsColumn to Job Functions table #2101' #1249

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[RFR] Test of Add 'ActionsColumn to Job Functions table #2101' #1249

merged 1 commit into from
Nov 5, 2024

Conversation

DvoraShechter1
Copy link
Contributor

@DvoraShechter1 DvoraShechter1 commented Nov 4, 2024 •
edited
Loading

@DvoraShechter1
Updating tests to align with ControlTableActionButtons changes from P…
75cb623 
…R #2101, including permissions, tooltips, and button structure adjustments.

Signed-off-by: DvoraShechter1 <[email protected]>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 4, 2024

Hi @DvoraShechter1. Thanks for your PR.

I'm waiting for a konveyor member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mguetta1
mguetta1 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mguetta1 mguetta1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DvoraShechter1!
LGTM

@mguetta1
Copy link
Contributor

mguetta1 commented Nov 4, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2024
ibragins
ibragins approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibragins ibragins merged commit b4c734e into konveyor:main Nov 5, 2024
8 of 9 checks passed
@mguetta1 mguetta1 mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetta1 mguetta1 mguetta1 approved these changes

@ibragins ibragins ibragins approved these changes

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DvoraShechter1 @mguetta1 @ibragins