Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix source analysis test case #1295

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[RFR] Fix source analysis test case #1295

merged 1 commit into from
Jan 7, 2025

Conversation

kpunwatk
Copy link
Collaborator

@kpunwatk kpunwatk commented Dec 16, 2024 •
edited
Loading

No description provided.

@kpunwatk kpunwatk force-pushed the source_custom_fix branch 4 times, most recently from cedb61e to cec22e2 Compare December 23, 2024 07:17
@kpunwatk kpunwatk changed the title [RFR] Fix source analysis custom rule test case [RFR] Fix source analysis test case Dec 23, 2024
ibragins
ibragins approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but until tier0 will start working we can't merge it, even if failure us caused by minikube deployment failure and is not related to this PR.

@kpunwatk
Copy link
Collaborator Author

Hi @ibragins @abrugaro noticed tier0 is successful, Could you please merge this PR?

@abrugaro
Copy link
Collaborator

Hi @kpunwatk, I see that some tests are not marked with a bug number and they're failing as well in https://jenkins-csb-migrationqe-main.dno.corp.redhat.com/blue/organizations/jenkins/mta%2Ftackle-ui-tests-pr-tester/detail/PR-1295/12/pipeline

@kpunwatk kpunwatk force-pushed the source_custom_fix branch 2 times, most recently from a2f7ec1 to 7824467 Compare December 30, 2024 10:28
@kpunwatk
Copy link
Collaborator Author

Hi @kpunwatk, I see that some tests are not marked with a bug number and they're failing as well in https://jenkins-csb-migrationqe-main.dno.corp.redhat.com/blue/organizations/jenkins/mta%2Ftackle-ui-tests-pr-tester/detail/PR-1295/12/pipeline

Hi @abrugaro, thank you for pointing that out. I only expect the Source analysis on tackle app public with custom rule test case to fail, as we're waiting for Dylan's response regarding the finding. I believe the rest should succeed now, I've Pushed some changes.
Triggered a jenkins run, will attach the Screenshot and console log shortly.

@kpunwatk kpunwatk self-assigned this Dec 31, 2024
@kpunwatk
Copy link
Collaborator Author

Jenkins Run
Screenshot from 2024-12-31 13-27-40

Regarding the OpenJDK21 Source + dependencies analysis on the Daytrader app test case, it appears to be a bug due to the fluctuating effort count. I will file it after discussing it with the developers once they return.

@kpunwatk
Copy link
Collaborator Author

kpunwatk commented Jan 2, 2025

Hi @abrugaro @ibragins if you could review again and merge this PR, Please

@ibragins
Copy link
Collaborator

ibragins commented Jan 2, 2025

Regarding the OpenJDK21 Source + dependencies analysis on the Daytrader app test case, it appears to be a bug due to the fluctuating effort count. I will file it after discussing it with the developers once they return.

Sorry, but we can't merge a PR with failing test without a bug number for it. Let's wait until you will file it and put here the number.

@kpunwatk
[RFR] Fix Source analysis test case
8d6063d 
	modified:   cypress/e2e/models/migration/applicationinventory/analysis.ts
	modified:   cypress/e2e/tests/migration/applicationinventory/analysis/source_analysis.test.ts
	modified:   cypress/e2e/views/analysis.view.ts
	modified:   cypress/fixtures/analysis.json

Signed-off-by: Karishma Punwatkar <[email protected]>

	modified:   cypress/e2e/models/migration/applicationinventory/analysis.ts
	modified:   cypress/e2e/tests/migration/applicationinventory/analysis/source_analysis.test.ts
	modified:   cypress/e2e/views/analysis.view.ts
	modified:   cypress/fixtures/analysis.json

	modified:   cypress/fixtures/analysis.json

	modified:   cypress/e2e/tests/migration/applicationinventory/analysis/source_analysis.test.ts

	modified:   cypress/fixtures/analysis.json

	modified:   cypress/e2e/tests/migration/applicationinventory/analysis/source_analysis.test.ts
@kpunwatk
Copy link
Collaborator Author

kpunwatk commented Jan 6, 2025

Regarding the OpenJDK21 Source + dependencies analysis on the Daytrader app test case, it appears to be a bug due to the fluctuating effort count. I will file it after discussing it with the developers once they return.

Sorry, but we can't merge a PR with failing test without a bug number for it. Let's wait until you will file it and put here the number.

Done @ibragins added the bug number to the test case Bug MTA-4417: OpenJDK21 Source + dependencies analysis on daytrader app Please review again, Thanks!

@sshveta sshveta changed the title [RFR] Fix source analysis test case [WIP] Fix source analysis test case Jan 7, 2025
@sshveta sshveta changed the title [WIP] Fix source analysis test case [RFR] Fix source analysis test case Jan 7, 2025
@sshveta sshveta merged commit 14bcbc8 into konveyor:main Jan 7, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrugaro abrugaro abrugaro approved these changes

@ibragins ibragins ibragins approved these changes

@sshveta sshveta sshveta approved these changes

Assignees

@kpunwatk kpunwatk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpunwatk @abrugaro @ibragins @sshveta