[RFR]marking mta bug for test and adding success message check #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neilhamza <[email protected]>
abrugaro
requested changes
Oct 3, 2023
cypress/e2e/tests/migration/controls/businessservices/crud.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Neilhamza <[email protected]>
nachandr
approved these changes
Oct 3, 2023
abrugaro
approved these changes
Oct 5, 2023
sshveta
reviewed
Oct 5, 2023
| @@ -77,24 +92,34 @@ describe(["@tier1", "@interop"], "Business service CRUD operations", () => { | |||
| stakeholder.name | |||
| ); | |||
| businessService.create(); | |||
| checkSuccessAlert( | |||
There was a problem hiding this comment.
Sorry for late comment.
We are adding these message checks only once in a test so that if message changes only one test fails .
So in the CRUD test we assert for success create , edit and delete messages .
Not in any other tests.
Please remove them in a separate PR .
There was a problem hiding this comment.
Yeah but this is the CRUD test, I may be missing something but I think this is the place to check for notifications.
There was a problem hiding this comment.
I know all are crud tests in this file but validation in one test is good.
There was a problem hiding this comment.
Oh ok, makes sense, thanks for clarifying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkins : currently failing due to a bug, marked on test