Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR][AF] Fix for stakeholder groups tests #732

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

kpunwatk
Copy link
Collaborator

@kpunwatk kpunwatk commented Oct 4, 2023

Signed-off-by: Karishma Punwatkar [email protected]

modified:   cypress/e2e/views/common.view.ts

Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both helpers now share the same selector, we can make just one constant stakeHolderGroupHelper.

@kpunwatk kpunwatk force-pushed the stakeholderGroup-fix branch from 2e9e501 to f76ff45 Compare October 4, 2023 10:27
@kpunwatk
Copy link
Collaborator Author

kpunwatk commented Oct 4, 2023

If both helpers now share the same selector, we can make just one constant stakeHolderGroupHelper.

Nice suggestion @abrugaro. Pushed the changes, Thanks !

@kpunwatk kpunwatk force-pushed the stakeholderGroup-fix branch from f76ff45 to bd0a3a0 Compare October 4, 2023 10:49
Copy link
Collaborator

@midays midays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kpunwatk kpunwatk force-pushed the stakeholderGroup-fix branch 2 times, most recently from cd6bef3 to 992758a Compare October 5, 2023 12:03
Signed-off-by: Karishma Punwatkar <[email protected]>
Signed-off-by: Karishma Punwatkar <[email protected]>
@kpunwatk kpunwatk force-pushed the stakeholderGroup-fix branch from c716068 to d89f977 Compare October 5, 2023 12:08
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrugaro abrugaro merged commit 80a8ee3 into konveyor:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants