-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR][AF] Fix for stakeholder groups tests #732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both helpers now share the same selector, we can make just one constant stakeHolderGroupHelper
.
2e9e501
to
f76ff45
Compare
Nice suggestion @abrugaro. Pushed the changes, Thanks ! |
f76ff45
to
bd0a3a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cd6bef3
to
992758a
Compare
Signed-off-by: Karishma Punwatkar <[email protected]>
Signed-off-by: Karishma Punwatkar <[email protected]>
c716068
to
d89f977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Karishma Punwatkar [email protected]