[RFR] Add methods for questionnaire class #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nandini Chandra <[email protected]>
sshveta
reviewed
Oct 17, 2023
|
|
||
| export class AssessmentQuestionnaire { | ||
| public static fullUrl = Cypress.env("tackleUrl") + "/assessment"; | ||
|
|
||
| constructor( |
There was a problem hiding this comment.
Do we want to add fileName in constructor ?
That will make it a mandatory parameter to initialize this class.
User can just enable legacyPathfinder and not necessarily import one.
We can make fileName a parameter in importQuestionnaire() method and pass it from test in case when we are importing.
There was a problem hiding this comment.
@sshveta , thanks for the question.
My plan is to have the following methods for all questionnaires including the Legacy Pathfinder questionnaire. I know the import method is not relevant to the Legacy Pathfinder questionnaire since it's already available , but the other methods are . I'll look into this to figure out what works the best for this class.
- Import
- Export
- View
- Delete
- Enable
- Disable
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
ibragins
requested changes
Oct 18, 2023
cypress/e2e/models/administration/assessment_questionnaire/assessment_questionnaire.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/models/administration/assessment_questionnaire/assessment_questionnaire.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/models/administration/assessment_questionnaire/assessment_questionnaire.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/models/administration/assessment_questionnaire/assessment_questionnaire.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
changed the title
sshveta
requested changes
Oct 18, 2023
cypress/e2e/models/administration/assessment_questionnaire/assessment_questionnaire.ts
Show resolved
Hide resolved
cypress/e2e/models/administration/assessment_questionnaire/assessment_questionnaire.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Nandini Chandra <[email protected]>
sshveta
approved these changes
Oct 19, 2023
nachandr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do: