[RFR] Automate Application information test case #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpunwatk
force-pushed
the
pencil_icon_TC
branch
from
e6e4318 to
5c8c700
Compare
sshveta
requested changes
Nov 16, 2023
cypress/e2e/tests/migration/applicationinventory/applications/crud.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/applicationinventory/applications/crud.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/applicationinventory/applications/crud.test.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/tests/migration/applicationinventory/applications/crud.test.ts
Outdated
Show resolved
Hide resolved
| @@ -459,4 +474,9 @@ export class Application { | |||
| }); | |||
| }); | |||
| } | |||
| applicationInformation(): void { | |||
| this.applicationDetailsTab(details); | |||
There was a problem hiding this comment.
Rename this method to validateApplicationInfo() or if you are just clicking on pencil Icon here then rename it to
editApplicationFromApplicationProfile()
kpunwatk
force-pushed
the
pencil_icon_TC
branch
3 times, most recently
from
3d06767 to
f4986ab
Compare
kpunwatk
changed the title
kpunwatk
force-pushed
the
pencil_icon_TC
branch
from
f4986ab to
bc31485
Compare
sshveta
reviewed
Nov 27, 2023
cypress/e2e/types/types.ts
Outdated
| @@ -72,7 +72,7 @@ export type JiraConnectionData = { | |||
| }; | |||
|
|
|||
| export type applicationData = { | |||
| name: string; | |||
| name?: string; | |||
There was a problem hiding this comment.
Why are you making name optional ? Isn't it a mandatory field ?
kpunwatk
force-pushed
the
pencil_icon_TC
branch
2 times, most recently
from
e2a3523 to
3485de4
Compare
Signed-off-by: Karishma Punwatkar <[email protected]> modified: cypress/e2e/models/migration/applicationinventory/application.ts modified: cypress/e2e/tests/migration/applicationinventory/applications/create.test.ts modified: cypress/e2e/types/constants.ts modified: cypress/e2e/types/types.ts modified: cypress/e2e/views/applicationinventory.view.ts
kpunwatk
force-pushed
the
pencil_icon_TC
branch
from
3485de4 to
3d0fd5e
Compare
|
Jenkins run pass |
sshveta
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karishma Punwatkar [email protected]