[RFR][JF]Fixed Interlinked test and application with force reload in after all… #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sshveta
commented
Nov 16, 2023
sshveta
commented
- Fixed Interlinked test
- Lot of application tests do not clean up because of failures , added forceReload in after all methods so that applications clean up .
added 2 commits
November 16, 2023 11:17
… method Signed-off-by: Shveta Sachdeva <[email protected]>
… method Signed-off-by: Shveta Sachdeva <[email protected]>
abrugaro
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
LGTM.
Since we're modifying all the methods to clean up the state, it'd be good to take the best practices into account by moving the cleanup to the beforeEach hooks
https://docs.cypress.io/guides/references/best-practices#State-reset-should-go-before-each-test
This of course can be done in a different PR.
added 2 commits
November 17, 2023 10:17
Signed-off-by: Shveta Sachdeva <[email protected]>
Signed-off-by: Shveta Sachdeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.