[RFR] [NA] Retake assessment questionnaire #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nandini Chandra <[email protected]>
nachandr
changed the title
Signed-off-by: Nandini Chandra <[email protected]>
sshveta
approved these changes
Nov 17, 2023
sshveta
reviewed
Nov 17, 2023
cypress/e2e/models/migration/applicationinventory/assessment.ts
Outdated
Show resolved
Hide resolved
sshveta
reviewed
Nov 17, 2023
cypress/e2e/models/migration/applicationinventory/assessment.ts
Outdated
Show resolved
Hide resolved
sshveta
requested changes
Nov 17, 2023
Signed-off-by: Nandini Chandra <[email protected]>
Signed-off-by: Nandini Chandra <[email protected]>
|
Results : pass |
sshveta
reviewed
Nov 17, 2023
| if (applicationOpen) { | ||
| Application.open(); | ||
| this.selectApplication(); | ||
| clickItemInKebabMenu(this.name, "Assess"); |
There was a problem hiding this comment.
Suggestion : These three lines can go in a method called clickAssessButton()
and that can be called in two methods .But it is an optional change .
sshveta
approved these changes
Nov 17, 2023
Signed-off-by: Nandini Chandra <[email protected]>
|
Results : PASS CI run is stuck . So, I re-ran the PR on Jenkins today. |
sshveta
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate questionnaire retake