Skip to content

Commit

Permalink
✨ Support succeeded with addon rule errors. (#103)
Browse files Browse the repository at this point in the history
Errors listed by the analyzer in the report (errors array) are reported
by the addon as TaskReport errors but the TaskReport.Status is not set
to `Failed`.

Requires: konveyor/tackle2-hub#681

---------

Signed-off-by: Jeff Ortel <[email protected]>
  • Loading branch information
jortel authored Jul 10, 2024
1 parent 452b4ee commit 3f0aed6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ func main() {
if errors.As(err, &ruleErr) {
ruleErr.Report()
err = nil
} else {
return
}
return
}
//
// Facts
Expand All @@ -151,7 +152,6 @@ func main() {
return
}
}

//
// Tags.
if d.Tagger.Enabled {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/gin-gonic/gin v1.9.1
github.com/konveyor/analyzer-lsp v0.4.0-alpha.1.0.20240603131628-bc4ff29956a2
github.com/konveyor/tackle2-addon v0.4.0-alpha.1
github.com/konveyor/tackle2-hub v0.4.1-0.20240611123927-c28822efd364
github.com/konveyor/tackle2-hub v0.5.0-beta.1
github.com/onsi/gomega v1.27.6
github.com/rogpeppe/go-internal v1.10.0
go.lsp.dev/uri v0.3.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ github.com/konveyor/analyzer-lsp v0.4.0-alpha.1.0.20240603131628-bc4ff29956a2 h1
github.com/konveyor/analyzer-lsp v0.4.0-alpha.1.0.20240603131628-bc4ff29956a2/go.mod h1:GXkSykQ84oE1SyMvFko9s9wRn/FMdl4efLLWSjMX2nU=
github.com/konveyor/tackle2-addon v0.4.0-alpha.1 h1:YgkA3fUAFeaV5K22WpcnxvdhWJxvE/y+Vqn6Z8NvPMs=
github.com/konveyor/tackle2-addon v0.4.0-alpha.1/go.mod h1:d5jsa9qR1PKF8J7ZZcxfg9K+KFScu5YJQrp1Yzhjoss=
github.com/konveyor/tackle2-hub v0.4.1-0.20240611123927-c28822efd364 h1:uOOgOM5n7X8vNhUdpKfAiAF70NfAU0OtTGlSx53QWyg=
github.com/konveyor/tackle2-hub v0.4.1-0.20240611123927-c28822efd364/go.mod h1:5c5A3i/oARdUp1yo+iYJFFvsIlsbsVGBZT7/CQji9YY=
github.com/konveyor/tackle2-hub v0.5.0-beta.1 h1:wauq0BdSFd6Uq78TUWbjNMHBv/MVyYruvhuQSKUV8OM=
github.com/konveyor/tackle2-hub v0.5.0-beta.1/go.mod h1:5c5A3i/oARdUp1yo+iYJFFvsIlsbsVGBZT7/CQji9YY=
github.com/kr/pretty v0.2.0/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
Expand Down

0 comments on commit 3f0aed6

Please sign in to comment.