Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Run the shim on each directory. #126

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Aug 7, 2024

Ensure each ruleDir (--rules) contains a ruleset.yaml.
Run the shim on all ruleDir. This includes rules/files which contains uploaded individual rule files.
This is needed because the shim creates converted files in the root of the output dir.

https://issues.redhat.com/browse/MTA-3163
https://issues.redhat.com/browse/MTA-3330

jortel added 5 commits August 7, 2024 13:53
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel added this to the v0.5.2 milestone Aug 7, 2024
@jortel jortel added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch. label Aug 12, 2024
@jortel jortel requested a review from mansam August 12, 2024 16:56
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel merged commit 4ce23c3 into konveyor:main Aug 21, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 21, 2024
Ensure each _ruleDir_ (`--rules`) contains a `ruleset.yaml`.
Run the shim on all _ruleDir_. This includes rules/files which contains
uploaded individual rule files.
This is needed because the shim creates converted files in the root of
the output dir.

https://issues.redhat.com/browse/MTA-3163
https://issues.redhat.com/browse/MTA-3330

---------

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
jortel added a commit that referenced this pull request Aug 26, 2024
Ensure each _ruleDir_ (`--rules`) contains a `ruleset.yaml`.
Run the shim on all _ruleDir_. This includes rules/files which contains
uploaded individual rule files.
This is needed because the shim creates converted files in the root of
the output dir.

https://issues.redhat.com/browse/MTA-3163
https://issues.redhat.com/browse/MTA-3330

---------

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Jeff Ortel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.5 This PR should be cherry-picked to release-0.5 branch.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants