-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Run the shim on each directory. #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
added
the
cherry-pick/release-0.5
This PR should be cherry-picked to release-0.5 branch.
label
Aug 12, 2024
mansam
approved these changes
Aug 16, 2024
aufi
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jeff Ortel <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Ensure each _ruleDir_ (`--rules`) contains a `ruleset.yaml`. Run the shim on all _ruleDir_. This includes rules/files which contains uploaded individual rule files. This is needed because the shim creates converted files in the root of the output dir. https://issues.redhat.com/browse/MTA-3163 https://issues.redhat.com/browse/MTA-3330 --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
jortel
added a commit
that referenced
this pull request
Aug 26, 2024
Ensure each _ruleDir_ (`--rules`) contains a `ruleset.yaml`. Run the shim on all _ruleDir_. This includes rules/files which contains uploaded individual rule files. This is needed because the shim creates converted files in the root of the output dir. https://issues.redhat.com/browse/MTA-3163 https://issues.redhat.com/browse/MTA-3330 --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
This was referenced Oct 1, 2024
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure each ruleDir (
--rules
) contains aruleset.yaml
.Run the shim on all ruleDir. This includes rules/files which contains uploaded individual rule files.
This is needed because the shim creates converted files in the root of the output dir.
https://issues.redhat.com/browse/MTA-3163
https://issues.redhat.com/browse/MTA-3330