✨ Inject typed values. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
dymurray
added
the
cherry-pick/release-0.6
dymurray
reviewed
Jan 9, 2025
cmd/injector.go
Outdated
| err = errors.New("expected: int|boolean|string") | ||
| } | ||
| default: | ||
| err = errors.New("expected: integer|boolean") |
There was a problem hiding this comment.
why is this only integer|boolean?
There was a problem hiding this comment.
I added string afterwards and forgot to add here. Fixed.
dymurray
reviewed
Jan 9, 2025
| switch strings.ToLower(f.Type) { | ||
| case "string": | ||
| cast = fmt.Sprintf("%v", object) | ||
| case "integer": |
There was a problem hiding this comment.
Consider supporting case "integer" | "int" and case "boolean" | "bool"
There was a problem hiding this comment.
Thinking longer form of integer|boolean|string would be more language (Go) agnostic. Also, supporting the shorter forms would be more to document. Seemed like less/simpler choices would be best.
dymurray
approved these changes
Jan 9, 2025
Signed-off-by: Jeff Ortel <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
Inject variables using true or _cast_ types when variable references not
embedded in other text.
Consider:
```
metadata:
provider:
address: localhost:$(PORT)
initConfig:
- providerSpecificConfig:
mavenInsecure: $(maven.insecure)
mavenSettingsFile: $(maven.settings.path)
name: java
resources:
- selector: identity:kind=maven
fields:
- key: maven.settings.path
name: settings
path: /shared/creds/maven/settings.xml
- selector: setting:key=mvn.insecure.enabled
fields:
- key: maven.insecure
name: value
```
For example:
```
mavenInsecure = $(maven.insecure)
```
$(maven.insecure) has a _true_ type of boolean (as stored in the db) so
it will be injected as:
```yaml
mavenInsecure: true
```
For cases when the _true_ type is different, an optional `type` field
may be used to cast. In the previous example, if maven.insecure was
stored as a string "true" but need to be injected as a boolean, the type
field may be used.
```
- selector: setting:key=mvn.insecure.enabled
fields:
- key: maven.insecure
name: value
type: boolean
```
While we're at it, (and to help with testing), support for _default_
values added.
```
- selector: setting:key=mvn.insecure.enabled
fields:
- key: maven.insecure
name: value
type: boolean
default: false
```
---------
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
dymurray
pushed a commit
that referenced
this pull request
Jan 10, 2025
Inject variables using true or _cast_ types when variable references not
embedded in other text.
Consider:
```
metadata:
provider:
address: localhost:$(PORT)
initConfig:
- providerSpecificConfig:
mavenInsecure: $(maven.insecure)
mavenSettingsFile: $(maven.settings.path)
name: java
resources:
- selector: identity:kind=maven
fields:
- key: maven.settings.path
name: settings
path: /shared/creds/maven/settings.xml
- selector: setting:key=mvn.insecure.enabled
fields:
- key: maven.insecure
name: value
```
For example:
```
mavenInsecure = $(maven.insecure)
```
$(maven.insecure) has a _true_ type of boolean (as stored in the db) so
it will be injected as:
```yaml
mavenInsecure: true
```
For cases when the _true_ type is different, an optional `type` field
may be used to cast. In the previous example, if maven.insecure was
stored as a string "true" but need to be injected as a boolean, the type
field may be used.
```
- selector: setting:key=mvn.insecure.enabled
fields:
- key: maven.insecure
name: value
type: boolean
```
While we're at it, (and to help with testing), support for _default_
values added.
```
- selector: setting:key=mvn.insecure.enabled
fields:
- key: maven.insecure
name: value
type: boolean
default: false
```
---------
Signed-off-by: Jeff Ortel <[email protected]>
(cherry picked from commit 5e4a70d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject variables using true or cast types when variable references not embedded in other text.
Consider:
For example:
$(maven.insecure) has a true type of boolean (as stored in the db) so it will be injected as:
For cases when the true type is different, an optional
typefield may be used to cast. In the previous example, if maven.insecure was stored as a string "true" but need to be injected as a boolean, the type field may be used.While we're at it, (and to help with testing), support for default values added.