-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ discontinue using maven and analyzer-deps. #97
Conversation
} | ||
|
||
// buildMavenSettings creates maven settings. | ||
func (r *Mode) buildMavenSettings(application *api.Application) (err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hint: No longer used.
@@ -112,59 +91,3 @@ func (r *Mode) getArtifact() (err error) { | |||
r.path.binary = path.Join(BinDir, path.Base(r.Artifact)) | |||
return | |||
} | |||
|
|||
// mavenArtifact get maven artifact. | |||
func (r *Mode) mavenArtifact(application *api.Application, maven *repository.Maven) (err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hint: Delegated to provider.
Required by: konveyor/tackle2-addon-analyzer#97 --------- Signed-off-by: Jeff Ortel <[email protected]>
Short-term workaround. The UI merged a PR to prefixes the Application.Binary with "mvn://". This PR is a fall-back until #97 can be merged which requires an analyzer patch to fix the builtin provider. Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #93 Requires: - konveyor/tackle2-hub#668 - konveyor/analyzer-lsp#671 - konveyor/analyzer-lsp#686 --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
closes #93 Requires: - konveyor/tackle2-hub#668 - konveyor/analyzer-lsp#671 - konveyor/analyzer-lsp#686 --------- Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
Fix duplicate tagging introduced in #97 Moved to updateApplication(). Signed-off-by: Jeff Ortel <[email protected]>
Fix duplicate tagging introduced in #97 Moved to updateApplication(). Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
closes #121 The `addon.Activity()` reports addon activity which is appended to the TaskReport.Activity using a PUT. This will briefly acquire a DB transaction (in the hub). The builder MUST not report activity because the addon already has a transaction open in the hub because of the POST of the analysis report. This creates a DEADLOCK. **There is a race-condition**: This only happens when the hub begins the transaction before the dep writer reports the dep.yaml not found. I can force this by adding a sleep to where the writer reports this. I suspect the hub can be busy enough with UI GET requests to delay it beginning the analysis POST until after the builder reports the file not found. Flow: ``` addon hub | post analysis ----- >| | | begin tx | writer <-------------| read | writer: put task --> | begin tx (deadlock) ``` Regression added PR #97 Signed-off-by: Jeff Ortel <[email protected]>
closes #121 The `addon.Activity()` reports addon activity which is appended to the TaskReport.Activity using a PUT. This will briefly acquire a DB transaction (in the hub). The builder MUST not report activity because the addon already has a transaction open in the hub because of the POST of the analysis report. This creates a DEADLOCK. **There is a race-condition**: This only happens when the hub begins the transaction before the dep writer reports the dep.yaml not found. I can force this by adding a sleep to where the writer reports this. I suspect the hub can be busy enough with UI GET requests to delay it beginning the analysis POST until after the builder reports the file not found. Flow: ``` addon hub | post analysis ----- >| | | begin tx | writer <-------------| read | writer: put task --> | begin tx (deadlock) ``` Regression added PR #97 Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
Fix duplicate tagging introduced in #97 Moved to updateApplication(). Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
closes #121 The `addon.Activity()` reports addon activity which is appended to the TaskReport.Activity using a PUT. This will briefly acquire a DB transaction (in the hub). The builder MUST not report activity because the addon already has a transaction open in the hub because of the POST of the analysis report. This creates a DEADLOCK. **There is a race-condition**: This only happens when the hub begins the transaction before the dep writer reports the dep.yaml not found. I can force this by adding a sleep to where the writer reports this. I suspect the hub can be busy enough with UI GET requests to delay it beginning the analysis POST until after the builder reports the file not found. Flow: ``` addon hub | post analysis ----- >| | | begin tx | writer <-------------| read | writer: put task --> | begin tx (deadlock) ``` Regression added PR #97 Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
closes #93
Requires: