🐛 Add svn support for tags. #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
commented
Nov 21, 2024
| @@ -6,6 +6,8 @@ require ( | |||
| github.com/clbanning/mxj v1.8.4 | |||
| github.com/jortel/go-utils v0.1.2 | |||
| github.com/konveyor/tackle2-hub v0.5.0-rc.1.0.20240726125502-8bb3c0911660 | |||
| github.com/onsi/gomega v1.27.6 | |||
| github.com/swaggo/swag v1.16.1 | |||
There was a problem hiding this comment.
hint: go mod tidy picked these up for some reason.
jortel
commented
Nov 21, 2024
| @@ -16,8 +16,10 @@ func init() { | |||
| HomeDir, _ = os.UserHomeDir() | |||
| } | |||
|
|
|||
| type Remote = api.Repository | |||
There was a problem hiding this comment.
hint: added for readability.
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
commented
Nov 21, 2024
| @@ -51,7 +53,7 @@ func New(destDir string, remote *api.Repository, identities []api.Ref) (r SCM, e | |||
| type SCM interface { | |||
| Validate() (err error) | |||
| Fetch() (err error) | |||
| Branch(name string) (err error) | |||
| Branch(ref string) (err error) | |||
There was a problem hiding this comment.
hint: This need to be more flexible. For git, it would be a branch or tag name. For svn, it needs to be a URL.
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
dymurray
added
the
cherry-pick/release-0.6
dymurray
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add svn support tags. Need to support 2 use cases:
tags/v1.2./trunkis no longer assumed.Some minor re-organization. Better practice to have exported (public) methods at the top.
ref: https://issues.redhat.com/browse/MTA-4236