👻 [Backport][MTA-1973] Change assessed logic for archetypes to handle…

… zero required (#609) @ibolton336: > Currently when no required questionnaires exist, archetypes are marked as `assessed:true` which results in additional UI code to rule out this case when calculating status. This PR aims to return `assessed: false` in the case of zero required assessments for an archetype. Signed-off-by: ibolton336 <[email protected]> Co-authored-by: Ian Bolton <[email protected]>
konveyor · Feb 28, 2024 · 95ffdfd · 95ffdfd
1 parent 0633e37
commit 95ffdfd
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/assessment/questionnaire.go b/assessment/questionnaire.go
@@ -51,6 +51,9 @@ func (r *QuestionnaireResolver) Required(id uint) (required bool) {
 // Assessed returns whether a slice contains a completed assessment for each of the required
 // questionnaires.
 func (r *QuestionnaireResolver) Assessed(assessments []Assessment) (assessed bool) {
+	if r.requiredQuestionnaires.Size() == 0 {
+		return false
+	}
 	answered := NewSet()
 	for _, a := range assessments {
 		if r.requiredQuestionnaires.Contains(a.QuestionnaireID) {