Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👻 [Backport][MTA-1973] Change assessed logic for archetypes to handle zero required #609

Merged
merged 1 commit into from
Feb 28, 2024
Merged

👻 [Backport][MTA-1973] Change assessed logic for archetypes to handle zero required #609

merged 1 commit into from
Feb 28, 2024

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Feb 28, 2024

@ibolton336:

Currently when no required questionnaires exist, archetypes are marked as assessed:true which results in additional UI code to rule out this case when calculating status. This PR aims to return assessed: false in the case of zero required assessments for an archetype.

@ibolton336 @mansam
👻 Change assessed logic for archetypes to handle zero required (konve…
d309d09 
…yor#601)

- Currently when no required questionnaires exist, archetypes are marked
as `assessed:true` which results in additional UI code to rule out this
case when calculating status. This PR aims to return `assessed: false`
in the case of zero required assessments for an archetype.

Signed-off-by: ibolton336 <[email protected]>
@mansam mansam requested review from jortel and ibolton336 February 28, 2024 16:27
@mansam
Copy link
Collaborator Author

mansam commented Feb 28, 2024

DCO is failing because I backported Ian's commit, but otherwise all checks are green. Merging.

@mansam mansam merged commit 95ffdfd into konveyor:release-0.3 Feb 28, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibolton336 ibolton336 ibolton336 approved these changes

@jortel jortel Awaiting requested review from jortel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansam @ibolton336