Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Go 1.20 #595

Merged
merged 10 commits into from
Jan 23, 2024
Merged

👻 Go 1.20 #595

merged 10 commits into from
Jan 23, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jan 18, 2024

upgrade Go 1.20.
Replaces gofmt with goimports. Documentation claims it performs the same formatting plus manages/orders imports.
Added missing packages in Makefile.
Updated the go.mod and ran go mod tidy.

Simplified controller-gen target.
Updated variable syntax with more traditional.

closes: #556

NOT FOR 0.3.

Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel requested a review from mansam January 18, 2024 19:34
Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel changed the title Go 1.20 👻 Go 1.20 Jan 18, 2024
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
@jortel jortel marked this pull request as ready for review January 19, 2024 15:55
Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jortel jortel merged commit f1989d5 into konveyor:main Jan 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Go 1.20.
2 participants