👻 Change assessed logic for archetypes to handle zero required #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
zero-required-assessments
branch
from
d79ff47 to
ff944e7
Compare
ibolton336
force-pushed
the
zero-required-assessments
branch
from
ff944e7 to
dee33ae
Compare
ibolton336
force-pushed
the
zero-required-assessments
branch
from
dee33ae to
9fd38d5
Compare
Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
zero-required-assessments
branch
from
9fd38d5 to
c4e41e2
Compare
mansam
pushed a commit
to mansam/tackle2-hub
that referenced
this pull request
Feb 28, 2024
…yor#601) - Currently when no required questionnaires exist, archetypes are marked as `assessed:true` which results in additional UI code to rule out this case when calculating status. This PR aims to return `assessed: false` in the case of zero required assessments for an archetype. Signed-off-by: ibolton336 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assessed:truewhich results in additional UI code to rule out this case when calculating status. This PR aims to returnassessed: falsein the case of zero required assessments for an archetype.