-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add filter/sort/pagination to /tasks. #640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
changed the title
Add filter/sort/pagination to /tasks.
✨ Add filter/sort/pagination to /tasks.
Jun 5, 2024
This was referenced Jun 5, 2024
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
mansam
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the CI failure (although that looks unrelated).
rszwajko
added a commit
to rszwajko/tackle2-ui
that referenced
this pull request
Jun 12, 2024
Part-of: konveyor#1931 Reference-Url: konveyor/tackle2-hub#640
rszwajko
added a commit
to rszwajko/tackle2-ui
that referenced
this pull request
Jun 12, 2024
Part-of: konveyor#1931 Reference-Url: konveyor/tackle2-hub#640 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
added a commit
to konveyor/tackle2-ui
that referenced
this pull request
Jun 13, 2024
Part-of: #1931 Reference-Url: konveyor/tackle2-hub#640 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
sjd78
added a commit
to konveyor/tackle2-ui
that referenced
this pull request
Jun 20, 2024
Resolves: #1938 Add a queued tasks count badge and a task list drawer. - Add a `TaskManagerContext` to control the count indicator and visibility of the drawer. This is a top level context so the task manager is available on all pages. The context itself monitors the task queue report endpoint[^1] that drives the notification badge count. - Use the standard `NotificationDrawer` attached to the `Page` layout to render the task manager item drawer. - The `TaskNotificationBadge` is integrated to the application's `HeaderApp`. - The `TaskManagerDrawer` shows the list of currently "queued" tasks[^2] in task id descending sort order (most recently created tasks on the top). - Each task item is rendered in a "collapsed" state and after a click will render "expanded". The expanded state include the started timestamp. - **_Note 1:_** Until fetch more / infinite scroll is implemented in the task manager drawer list, only the first 20 queued tasks will be displayed. - **_Note 2:_** Task actions need to be added to the task items. These should reuse the same set of actions as the task table in #1957. Related changes: - Update the `HeaderApp` to handle visibility of masthead toolbar items at the `ToolbarGroup` level. - Rename `SSOMenu` to `SsoToolbarItem`. - Updated the typing on a few task related API functions. [^1]: konveyor/tackle2-hub#641 [^2]: konveyor/tackle2-hub#640 --------- Signed-off-by: Scott J Dickerson <[email protected]>
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support: konveyor/tackle2-ui#1931
Note: UI team requested alias for queued states to be supported in filter. Ex:
?filter=state:queued
.closes: #641