Skip to content

Commit

Permalink
PR review changes
Browse files Browse the repository at this point in the history
Signed-off-by: Scott J Dickerson <[email protected]>
  • Loading branch information
sjd78 committed Nov 7, 2023
1 parent cb1190f commit c9a4428
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions client/src/app/components/Autocomplete.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export interface AutocompleteOptionProps {
/** the text to display for the option */
name: string | (() => string);

/** the text to display on a label when the option is selected, defaults to `name` if no supplied */
/** the text to display on a label when the option is selected, defaults to `name` if not supplied */
labelName?: string | (() => string);

/** the tooltip to display on the Label when the option has been selected */
Expand Down Expand Up @@ -264,12 +264,7 @@ export const Autocomplete: React.FC<IAutocompleteProps> = ({
);

const menu = (
<Menu
ref={menuRef}
// onSelect={handleMenuOnSelect}
onKeyDown={handleMenuOnKeyDown}
isScrollable
>
<Menu ref={menuRef} onKeyDown={handleMenuOnKeyDown} isScrollable>
<MenuContent>
<MenuList>
{/* if supplied, add the menu heading */}
Expand Down Expand Up @@ -326,7 +321,7 @@ export const Autocomplete: React.FC<IAutocompleteProps> = ({
color={labelColor}
onClose={() => deleteSelectionByItemId(id)}

Check warning on line 322 in client/src/app/components/Autocomplete.tsx

View check run for this annotation

Codecov / codecov/patch

client/src/app/components/Autocomplete.tsx#L322

Added line #L322 was not covered by tests
>
{labelName ? toString(labelName) : toString(name)}
{toString(labelName || name)}
</Label>
</LabelToolip>
</FlexItem>
Expand Down

0 comments on commit c9a4428

Please sign in to comment.