Skip to content

Commit

Permalink
Pass new feature flags to every usage
Browse files Browse the repository at this point in the history
Signed-off-by: Mike Turley <[email protected]>
  • Loading branch information
mturley committed Oct 12, 2023
1 parent 1fb049c commit cbb8a68
Show file tree
Hide file tree
Showing 17 changed files with 54 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,11 @@ export const ApplicationsTableAnalyze: React.FC = () => {
analysis: "Analysis",
tags: "Tags",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isSelectionEnabled: true,
isActiveRowEnabled: true,
sortableColumns: ["name", "description", "businessService", "tags"],
initialSort: { columnKey: "name", direction: "asc" },
getSortValues: (app) => ({
Expand Down Expand Up @@ -324,7 +329,6 @@ export const ApplicationsTableAnalyze: React.FC = () => {
],
initialItemsPerPage: 10,
hasActionsColumn: true,
isSelectionEnabled: true,
});

const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,10 @@ export const ApplicationsTable: React.FC = () => {
review: "Review",
tags: "Tags",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isActiveRowEnabled: true,
sortableColumns: ["name", "description", "businessService", "tags"],
initialSort: { columnKey: "name", direction: "asc" },
getSortValues: (app) => ({
Expand Down
7 changes: 5 additions & 2 deletions client/src/app/pages/archetypes/archetypes-page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ const Archetypes: React.FC = () => {
applications: t("terms.applications"),
},

isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isActiveRowEnabled: true,

filterCategories: [
{
key: "name",
Expand All @@ -135,8 +140,6 @@ const Archetypes: React.FC = () => {
name: archetype.name ?? "",
}),
initialSort: { columnKey: "name", direction: "asc" },

isPaginationEnabled: true,
});
const {
currentPageItems,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ const AssessmentSettings: React.FC = () => {
rating: "Rating",
createTime: "Date imported",
},
isSelectionEnabled: false,
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
hasActionsColumn: true,
filterCategories: [
{
Expand All @@ -135,7 +137,6 @@ const AssessmentSettings: React.FC = () => {
createTime: questionnaire.createTime || "",
}),
initialSort: { columnKey: "name", direction: "asc" },
isPaginationEnabled: true,
isLoading: isFetching,
});
const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ const QuestionnairesTable: React.FC<QuestionnairesTableProps> = ({
columnNames: {
questionnaires: tableName,
},
hasActionsColumn: false,
isPaginationEnabled: false,
variant: "compact",
});

Expand Down
5 changes: 4 additions & 1 deletion client/src/app/pages/controls/stakeholders/stakeholders.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ export const Stakeholders: React.FC = () => {
jobFunction: "Job function",
groupCount: "Group count",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isExpansionEnabled: true,
expandableVariant: "single",
hasActionsColumn: true,
filterCategories: [
Expand Down Expand Up @@ -165,7 +169,6 @@ export const Stakeholders: React.FC = () => {
jobFunction: item.jobFunction?.name || "",
}),
initialSort: { columnKey: "name", direction: "asc" },
isPaginationEnabled: true,
isLoading: isFetching,
});

Expand Down
4 changes: 4 additions & 0 deletions client/src/app/pages/dependencies/dependencies.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ export const Dependencies: React.FC = () => {
sha: "SHA",
version: "Version",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isActiveRowEnabled: true,
sortableColumns: ["name", "foundIn", "labels"],
initialSort: { columnKey: "name", direction: "asc" },
filterCategories: [
Expand Down
3 changes: 3 additions & 0 deletions client/src/app/pages/dependencies/dependency-apps-table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ export const DependencyAppsTable: React.FC<IDependencyAppsTableProps> = ({
// management (3rd party or not boolean... parsed from labels)
relationship: "Relationship",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
sortableColumns: ["name", "version"],
initialSort: { columnKey: "name", direction: "asc" },
filterCategories: [
Expand Down
4 changes: 3 additions & 1 deletion client/src/app/pages/external/jira/trackers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ export const JiraTrackers: React.FC = () => {
kind: `${t("terms.instance")} type`,
connection: "Connection",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
filterCategories: [
{
key: "name",
Expand Down Expand Up @@ -131,7 +134,6 @@ export const JiraTrackers: React.FC = () => {
url: tracker.url || "",
}),
sortableColumns: ["name", "url"],
isPaginationEnabled: true,
isLoading: isFetching,
});
const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ export const AffectedApplications: React.FC = () => {
effort: "Effort",
incidents: "Incidents",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isActiveRowEnabled: true,
sortableColumns: ["name", "businessService", "effort", "incidents"],
initialSort: { columnKey: "name", direction: "asc" },
filterCategories: useSharedAffectedApplicationFilterCategories(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ export const FileAllIncidentsTable: React.FC<
line: "Line #",
message: "Message",
},
isSortEnabled: true,
isPaginationEnabled: true,
sortableColumns: ["line", "message"],
initialSort: { columnKey: "line", direction: "asc" },
initialItemsPerPage: 10,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ export const IssueAffectedFilesTable: React.FC<
incidents: "Incidents",
effort: "Effort",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
sortableColumns: ["file", "incidents", "effort"],
initialSort: { columnKey: "file", direction: "asc" },
filterCategories: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,12 @@ export const ManageApplicationsForm: React.FC<ManageApplicationsFormProps> = ({
businessService: "Business service",
owner: "Owner",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isExpansionEnabled: true,
isSelectionEnabled: true,
initialSelected: assignedApplications,
isExpansionEnabled: true,
expandableVariant: "compound",
hasActionsColumn: true,
filterCategories: [
Expand Down Expand Up @@ -170,7 +173,6 @@ export const ManageApplicationsForm: React.FC<ManageApplicationsFormProps> = ({
owner: application.owner?.name || "",
}),
initialSort: { columnKey: "name", direction: "asc" },
isPaginationEnabled: true,
});
const {
currentPageItems,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ export const WaveStakeholdersTable: React.FC<IWaveStakeholdersTableProps> = ({
email: "Email",
groups: "Stakeholder groups",
},
isSortEnabled: true,
isPaginationEnabled: true,
hasActionsColumn: true,
getSortValues: (stakeholder) => ({
name: stakeholder.name || "",
Expand All @@ -35,7 +37,6 @@ export const WaveStakeholdersTable: React.FC<IWaveStakeholdersTableProps> = ({
email: stakeholder.email,
}),
sortableColumns: ["name", "jobFunction", "role", "email"],
isPaginationEnabled: true,
variant: "compact",
});
const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,15 @@ export const WaveApplicationsTable: React.FC<IWaveApplicationsTableProps> = ({
businessService: "Business service",
owner: "Owner",
},
isSortEnabled: true,
isPaginationEnabled: true,
hasActionsColumn: true,
getSortValues: (app) => ({
appName: app.name || "",
businessService: app.businessService?.name || "",
owner: app.owner?.name || "",
}),
sortableColumns: ["appName", "businessService", "owner"],
isPaginationEnabled: true,
variant: "compact",
});
const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ export const WaveStatusTable: React.FC<IWaveStatusTableProps> = ({
status: "Status",
issue: "Issue",
},
hasActionsColumn: true,
isSortEnabled: true,
isPaginationEnabled: true,
hasActionsColumn: true,
getSortValues: (app) => ({
appName: app.name || "",
status: app.comments || "",
issue: "",
}),
sortableColumns: ["appName", "status", "issue"],
isPaginationEnabled: true,
variant: "compact",
});
const {
Expand Down
5 changes: 4 additions & 1 deletion client/src/app/pages/migration-waves/migration-waves.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ export const MigrationWaves: React.FC = () => {
stakeholders: "Stakeholders",
status: "Status",
},
isFilterEnabled: true,
isSortEnabled: true,
isPaginationEnabled: true,
isExpansionEnabled: true,
isSelectionEnabled: true,
expandableVariant: "compound",
hasActionsColumn: true,
Expand All @@ -212,7 +216,6 @@ export const MigrationWaves: React.FC = () => {
endDate: migrationWave.endDate || "",
}),
initialSort: { columnKey: "startDate", direction: "asc" },
isPaginationEnabled: true,
isLoading: isFetching,
});
const {
Expand Down

0 comments on commit cbb8a68

Please sign in to comment.