Skip to content

Commit

Permalink
🐛 application can only have one review (#1693)
Browse files Browse the repository at this point in the history
https://issues.redhat.com/browse/MTA-1888

It appears that an application can only have a single review. So this
changes the Tab title from `Reviews` -> `Review` and drops the redundant
header inside.

Signed-off-by: David Zager <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
  • Loading branch information
djzager and ibolton336 authored Feb 22, 2024
1 parent 388a442 commit ce3cab5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ export const ApplicationDetailDrawer: React.FC<
</Tab>
<Tab
eventKey={TabKey.Reviews}
title={<TabTitleText>{t("terms.reviews")}</TabTitleText>}
title={<TabTitleText>{t("terms.review")}</TabTitleText>}
>
<ReviewFields application={application} />
</Tab>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@ import {
DescriptionListGroup,
DescriptionListTerm,
DescriptionListDescription,
Title,
TextContent,
} from "@patternfly/react-core";
import { Application, Archetype, Review } from "@app/api/models";
import spacing from "@patternfly/react-styles/css/utilities/Spacing/spacing";
import { useFetchReviewById, useFetchReviews } from "@app/queries/reviews";
import { useFetchArchetypes } from "@app/queries/archetypes";
import { EmptyTextMessage } from "@app/components/EmptyTextMessage";
Expand Down Expand Up @@ -75,11 +72,6 @@ export const ReviewFields: React.FC<{

return (
<>
<TextContent className={spacing.mtLg}>
<Title headingLevel="h3" size="md">
{t("terms.review")}
</Title>
</TextContent>
<DescriptionListGroup>
<DescriptionListTerm>{t("terms.proposedAction")}</DescriptionListTerm>
<DescriptionListDescription cy-data="proposed-action">
Expand Down

0 comments on commit ce3cab5

Please sign in to comment.