👻 Remove shared app filter and unused menuActions (#1402)

- Removes some old code I noticed after the dropdown update & analysis table PRs were merged - Menu actions are no longer used in the page header component and have been moved to the toolbar - Removes old shared app filter hook that is no longer in use Signed-off-by: ibolton336 <[email protected]>
konveyor · Sep 27, 2023 · e269b74 · e269b74
1 parent 9cf7840
commit e269b74
Show file tree

Hide file tree

Showing 11 changed files with 0 additions and 535 deletions.
diff --git a/client/src/app/components/MenuActions.tsx b/client/src/app/components/MenuActions.tsx
diff --git a/client/src/app/components/PageHeader.tsx b/client/src/app/components/PageHeader.tsx
@@ -8,15 +8,13 @@ import {
   Text,
 } from "@patternfly/react-core";
 import { BreadCrumbPath } from "./BreadCrumbPath";
-import { MenuActions } from "./MenuActions";
 import { HorizontalNav } from "./HorizontalNav";
 
 export interface PageHeaderProps {
   title: string;
   description?: React.ReactNode;
   breadcrumbs: { title: string; path: string | (() => void) }[];
   btnActions?: React.ReactNode;
-  menuActions: { label: string; callback: () => void }[];
   navItems?: { title: string; path: string }[];
 }
 
@@ -25,7 +23,6 @@ export const PageHeader: React.FC<PageHeaderProps> = ({
   description,
   breadcrumbs,
   btnActions,
-  menuActions,
   navItems,
 }) => {
   return (
@@ -42,11 +39,6 @@ export const PageHeader: React.FC<PageHeaderProps> = ({
             </TextContent>
           </SplitItem>
           {btnActions && <SplitItem>{btnActions}</SplitItem>}
-          {menuActions.length > 0 && (
-            <SplitItem>
-              <MenuActions actions={menuActions} />
-            </SplitItem>
-          )}
         </Split>
       </StackItem>
       {navItems && (

diff --git a/client/src/app/components/tests/MenuActions.test.tsx b/client/src/app/components/tests/MenuActions.test.tsx
diff --git a/client/src/app/components/tests/PageHeader.test.tsx b/client/src/app/components/tests/PageHeader.test.tsx
@@ -21,16 +21,6 @@ describe("PageHeader", () => {
             },
           ]}
           btnActions={<Button>send email</Button>}
-          menuActions={[
-            {
-              label: "Edit",
-              callback: jest.fn(),
-            },
-            {
-              label: "Delete",
-              callback: jest.fn(),
-            },
-          ]}
           navItems={[
             {
               title: "Overview",

diff --git a/client/src/app/components/tests/__snapshots__/MenuActions.test.tsx.snap b/client/src/app/components/tests/__snapshots__/MenuActions.test.tsx.snap
diff --git a/client/src/app/components/tests/__snapshots__/PageHeader.test.tsx.snap b/client/src/app/components/tests/__snapshots__/PageHeader.test.tsx.snap
@@ -94,42 +94,6 @@ exports[`PageHeader Renders without crashing 1`] = `
                 send email
               </button>
             </div>
-            <div
-              class="pf-v5-l-split__item"
-            >
-              <button
-                aria-expanded="false"
-                class="pf-v5-c-menu-toggle"
-                type="button"
-              >
-                <span
-                  class="pf-v5-c-menu-toggle__text"
-                >
-                  Actions
-                </span>
-                <span
-                  class="pf-v5-c-menu-toggle__controls"
-                >
-                  <span
-                    class="pf-v5-c-menu-toggle__toggle-icon"
-                  >
-                    <svg
-                      aria-hidden="true"
-                      class="pf-v5-svg"
-                      fill="currentColor"
-                      height="1em"
-                      role="img"
-                      viewBox="0 0 320 512"
-                      width="1em"
-                    >
-                      <path
-                        d="M31.3 192h257.3c17.8 0 26.7 21.5 14.1 34.1L174.1 354.8c-7.8 7.8-20.5 7.8-28.3 0L17.2 226.1C4.6 213.5 13.5 192 31.3 192z"
-                      />
-                    </svg>
-                  </span>
-                </span>
-              </button>
-            </div>
           </div>
         </div>
         <div
@@ -291,42 +255,6 @@ exports[`PageHeader Renders without crashing 1`] = `
               send email
             </button>
           </div>
-          <div
-            class="pf-v5-l-split__item"
-          >
-            <button
-              aria-expanded="false"
-              class="pf-v5-c-menu-toggle"
-              type="button"
-            >
-              <span
-                class="pf-v5-c-menu-toggle__text"
-              >
-                Actions
-              </span>
-              <span
-                class="pf-v5-c-menu-toggle__controls"
-              >
-                <span
-                  class="pf-v5-c-menu-toggle__toggle-icon"
-                >
-                  <svg
-                    aria-hidden="true"
-                    class="pf-v5-svg"
-                    fill="currentColor"
-                    height="1em"
-                    role="img"
-                    viewBox="0 0 320 512"
-                    width="1em"
-                  >
-                    <path
-                      d="M31.3 192h257.3c17.8 0 26.7 21.5 14.1 34.1L174.1 354.8c-7.8 7.8-20.5 7.8-28.3 0L17.2 226.1C4.6 213.5 13.5 192 31.3 192z"
-                    />
-                  </svg>
-                </span>
-              </span>
-            </button>
-          </div>
         </div>
       </div>
       <div