✨ Archetype drawer #1377
Merged
✨ Archetype drawer #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
approved these changes
Sep 20, 2023
Enable row selection on the Archetype table such that clicking an archetype row will display a details drawer with the archetype's details. `PageDrawerContent` in `PageDrawerContext.tsx` extended to have separate drawer header and content components. This allows the header and the content to have appropriate patternfly styling. Resolves: konveyor#1366 Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
archetype-drawer
branch
from
972bde3 to
977829c
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
- Coverage 41.48% 41.44% -0.04%
==========================================
Files 137 137
Lines 4288 4292 +4
Branches 1034 1038 +4
==========================================
Hits 1779 1779
- Misses 2420 2424 +4
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mturley
approved these changes
Sep 20, 2023
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable row selection on the Archetype table such that clicking an archetype row will display a details drawer with the archetype's details.
PageDrawerContentinPageDrawerContext.tsxextended to have separate drawer header and content components. This allows the header and the content to have appropriate patternfly styling.Resolves: #1366
Screen shot:
