✨ Reports - Current Landscape update risk handling #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom assessments changes risk and confidence to be accessed from
`Assessment` and not `Application`. The reports page in general, and
the `Landscape` component in specific need to be updated to use risk
values from `Assessment`.
Summary of Change:
- `Reports`
- Fetch `Questionnaires` and `Assessments` to allow easy use
in the Questionnaire select menu
- Adjust the `Card`s to be clickable and selectable when we provide
custom actions (to avoid a console warning)
- `Landscape`
- Use data from props instead of fetching any additional data. The
containing component is now responsible for controlling the
source data.
- Aggregate risk data into buckets matching `Risk` options
- Setup responsive layout so the donut charts wrap nicely when the
view becomes narrow
- `Donut`
- Force `id` to be provided
- Set the width to `200px`
- Make sure content lines up centered in its container
- Deprecated `useFetchRisks()`
Enhancement: https://github.com/konveyor/enhancements/blob/90b827b68cc367284a66bf66f087d5c263487e05/enhancements/assessment-module/README.md#changes-in-the-application-reports-view
Part Of: konveyor#1305
Follow Up: konveyor#1374
Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
force-pushed
the
reports_landscape_all
branch
from
5c883b0 to
b97b11a
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 41.34% 41.34%
=======================================
Files 138 138
Lines 4334 4334
Branches 1039 1039
=======================================
Hits 1792 1792
Misses 2454 2454
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Sep 25, 2023
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Custom assessments changes risk and confidence to be accessed from
Assessmentand notApplication. The reports page in general, and theLandscapecomponent in specific need to be updated to use risk values fromAssessment.Changes
ReportsQuestionnairesandAssessmentsto allow easy use in the Questionnaire select menuCards to be clickable and selectable when we provide custom actions (to avoid a console warning)LandscapeRiskoptions - Setup responsive layout so the donut charts wrap nicely when the view becomes narrowDonutidto be provided200pxDeprecated
useFetchRisks()Screenshots
All questionnaires:
Single questionnaire:
References
Enhancement: https://github.com/konveyor/enhancements/blob/90b827b68cc367284a66bf66f087d5c263487e05/enhancements/assessment-module/README.md#changes-in-the-application-reports-view
Part Of: #1305
Follow Up: #1374