Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Don't allow an archetype to be assessed if empty #1399

Closed
wants to merge 2 commits into from

Conversation

ibolton336
Copy link
Member

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change is fine, but I don't understand why the issue was raised. Nothing in the enhancement doc prevents reviewing or assessing an empty archetype.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fbd5e3d) 41.31% compared to head (f6f9308) 41.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   41.31%   41.31%           
=======================================
  Files         138      138           
  Lines        4330     4330           
  Branches     1035     1035           
=======================================
  Hits         1789     1789           
  Misses       2453     2453           
  Partials       88       88           
Flag Coverage Δ
client 41.31% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants