Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix broken analysis report download #1407

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Sep 27, 2023

@ibolton336 ibolton336 force-pushed the broken-analysis-download branch from 6633a60 to a7cb60c Compare September 27, 2023 16:59
@ibolton336 ibolton336 marked this pull request as ready for review September 27, 2023 16:59
@ibolton336 ibolton336 changed the title wip 🐛 Fix broken analysis report download Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (8277208) 41.19% compared to head (983ff42) 41.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
- Coverage   41.19%   41.07%   -0.12%     
==========================================
  Files         139      139              
  Lines        4372     4404      +32     
  Branches     1007     1010       +3     
==========================================
+ Hits         1801     1809       +8     
- Misses       2559     2583      +24     
  Partials       12       12              
Flag Coverage Δ
client 41.07% <21.42%> (-0.12%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/api/rest.ts 50.42% <50.00%> (+0.70%) ⬆️
client/src/app/queries/questionnaires.ts 23.33% <25.00%> (+1.11%) ⬆️
client/src/app/queries/applications.ts 39.75% <16.66%> (-7.79%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranavgaikwad
Copy link

seems to have fixed the download issue:

Peek 2023-09-27 13-15

@ibolton336
Copy link
Member Author

@ibolton336 ibolton336 force-pushed the broken-analysis-download branch from 28c4a58 to 033af7e Compare September 27, 2023 18:54
@ibolton336 ibolton336 requested review from sjd78 and mturley October 3, 2023 23:58
@ibolton336 ibolton336 force-pushed the broken-analysis-download branch from a60e1c6 to 669757a Compare October 4, 2023 19:54
@ibolton336 ibolton336 force-pushed the broken-analysis-download branch from 669757a to 220af4a Compare October 4, 2023 19:54
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I test this PR rebased on current main, the download button fails for both report types. I can try rebuilding my operator and test again tomorrow.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with a fresh install of the operator and the download links are working for both the tar and the yaml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants