-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix broken analysis report download #1407
Conversation
6633a60
to
a7cb60c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
==========================================
- Coverage 41.19% 41.07% -0.12%
==========================================
Files 139 139
Lines 4372 4404 +32
Branches 1007 1010 +3
==========================================
+ Hits 1801 1809 +8
- Misses 2559 2583 +24
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
28c4a58
to
033af7e
Compare
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
a60e1c6
to
669757a
Compare
Signed-off-by: ibolton336 <[email protected]>
669757a
to
220af4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I test this PR rebased on current main, the download button fails for both report types. I can try rebuilding my operator and test again tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing with a fresh install of the operator and the download links are working for both the tar and the yaml files.
Resolves https://issues.redhat.com/browse/MTA-1369
Resolves https://issues.redhat.com/browse/MTA-1386