Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Convert dependency code to use rq & fix cyclic dep alert #1419

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Sep 29, 2023

@ibolton336 ibolton336 force-pushed the mta-1130 branch 2 times, most recently from fe26889 to 335a87e Compare September 29, 2023 18:18
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (73f375f) 41.08% compared to head (7187c32) 40.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   41.08%   40.93%   -0.15%     
==========================================
  Files         139      139              
  Lines        4403     4424      +21     
  Branches     1010     1013       +3     
==========================================
+ Hits         1809     1811       +2     
- Misses       2582     2601      +19     
  Partials       12       12              
Flag Coverage Δ
client 40.93% <14.63%> (-0.15%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/api/models.ts 100.00% <ø> (ø)
client/src/app/api/rest.ts 51.31% <18.18%> (+0.88%) ⬆️
client/src/app/queries/applications.ts 32.14% <13.33%> (-7.62%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 requested review from mturley and sjd78 October 3, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant