🐛 Fetch target images in auth envs #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1420 +/- ##
==========================================
- Coverage 41.25% 41.20% -0.05%
==========================================
Files 138 139 +1
Lines 4349 4371 +22
Branches 1005 1007 +2
==========================================
+ Hits 1794 1801 +7
- Misses 2543 2558 +15
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sjd78
requested changes
Sep 29, 2023
| @@ -68,6 +69,8 @@ export const TargetCard: React.FC<TargetCardProps> = ({ | |||
| const { t } = useTranslation(); | |||
| const [isCardSelected, setCardSelected] = React.useState(cardSelected); | |||
|
|
|||
| const [imageDataUrl, setImageDataUrl] = React.useState<string | null>(null); | |||
There was a problem hiding this comment.
It's not really a url anymore, it's just the image data itself, so.... s/imageDataUrl/imageData/
There was a problem hiding this comment.
Ok, so reading it again today (with less blurry eyes and more coffee) and it really is a data-url. So the name does make sense!
sjd78
reviewed
Sep 29, 2023
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
sjd78
approved these changes
Oct 2, 2023
ibolton336
added a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Oct 2, 2023
Closes https://issues.redhat.com/browse/MTA-1249?filter=-1 - Image was not being fetched in envs with auth enabled. Image tags (<img>) in HTML do not follow the same request mechanism as AJAX or fetch requests. They do not use the XMLHttpRequest or axios API, so they were not intercepted by axios middleware interceptor we have set up for API requests. --------- Signed-off-by: ibolton336 <[email protected]>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://issues.redhat.com/browse/MTA-1249?filter=-1