Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Update nav item and table header for assessment settings #1422

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

ibolton336
Copy link
Member

Closes https://issues.redhat.com/browse/MTA-1249?filter=-1

- Image was not being fetched in envs with auth enabled. Image tags
(<img>) in HTML do not follow the same request mechanism as AJAX or
fetch requests. They do not use the XMLHttpRequest or axios API, so they
were not intercepted by axios middleware interceptor we have set up for
API requests.

---------

Signed-off-by: ibolton336 <[email protected]>
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (81a05db) 41.19% compared to head (a66c2de) 41.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1422   +/-   ##
=======================================
  Coverage   41.19%   41.19%           
=======================================
  Files         139      139           
  Lines        4372     4372           
  Branches     1007     1007           
=======================================
  Hits         1801     1801           
  Misses       2559     2559           
  Partials       12       12           
Flag Coverage Δ
client 41.19% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/src/app/layout/SidebarApp/SidebarApp.tsx 26.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjd78 sjd78 merged commit b8f95bd into konveyor:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants