🌱 update to new wizard for assessment-wizard and custom-wizard-footer #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitdallas <[email protected]>
|
@gitdallas haha sorry about that! You can create a stakeholder in the "controls" section of the app. |
Signed-off-by: gitdallas <[email protected]>
gitdallas
force-pushed
the
chore/1244-update-dep-assessment-wiz-to-new
branch
from
025a3fb to
9c156aa
Compare
Signed-off-by: gitdallas <[email protected]>
Signed-off-by: gitdallas <[email protected]>
Signed-off-by: gitdallas <[email protected]>
Signed-off-by: gitdallas <[email protected]>
…/github.com/gitdallas/tackle2-ui into chore/1244-update-dep-assessment-wiz-to-new
Signed-off-by: gitdallas <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1473 +/- ##
==========================================
- Coverage 40.81% 40.69% -0.13%
==========================================
Files 139 139
Lines 4459 4463 +4
Branches 1018 1067 +49
==========================================
- Hits 1820 1816 -4
+ Misses 2627 2552 -75
- Partials 12 95 +83
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ibolton336
requested changes
Oct 16, 2023
client/src/app/pages/assessment/components/assessment-wizard/assessment-wizard.tsx
Show resolved
Hide resolved
ibolton336
requested changes
Oct 16, 2023
client/src/app/pages/assessment/components/assessment-wizard/assessment-wizard.tsx
Show resolved
Hide resolved
ibolton336
requested changes
Oct 16, 2023
client/src/app/pages/assessment/components/assessment-wizard/assessment-wizard.tsx
Show resolved
Hide resolved
|
Looking good - just a few small comments re: leftover function & useMemo usage. |
Signed-off-by: gitdallas <[email protected]>
Signed-off-by: gitdallas <[email protected]>
ibolton336
approved these changes
Oct 18, 2023
mturley
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like some thorough testing on this.
#1244