🐛 Identified risk refactor

[ibolton336]

• Drives the table from assessment data as requested
  Resolves https://issues.redhat.com/browse/MTA-1434?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (521be72) 40.70% compared to head (224fc14) 40.70%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   40.70%   40.70%           
=======================================
  Files         145      145           
  Lines        4589     4589           
  Branches     1076     1076           
=======================================
  Hits         1868     1868           
  Misses       2707     2707           
  Partials       14       14           

Flag	Coverage Δ
client	40.70% <ø> (ø)
server	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sjd78]

I couldn't test the table render with the one questionnaire I have locally -- the dreaded hack/import-questionnaire/cloud-native.yaml! Seems like this report table has some issues with questions that repeat across sections.

The code looks good, I just couldn't test it.

[sjd78]

So this will have the same problem of if an assessment has repeated questions / answers right?

Maybe building up a key based on the order fields would be better?

itemId = [
  assessment.id,
  section.order,
  question.order,
  answer.order,
].join(".");

[ibolton336]

I couldn't test the table render with the one questionnaire I have locally -- the dreaded hack/import-questionnaire/cloud-native.yaml! Seems like this report table has some issues with questions that repeat across sections.

The code looks good, I just couldn't test it.

Addressed this bug here: #1524

[sjd78]

LGTM!