👻 use pf5 select for set-targets

[gitdallas]

Also pulled the select out of the text-content wrapper which was throwing off some styles.

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6e4ae05) 40.49% compared to head (177a9ad) 39.41%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
...lient/src/app/components/SimpleSelectTypeahead.tsx	0.00%	7 Missing ⚠️
...pages/applications/analysis-wizard/set-targets.tsx	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
- Coverage   40.49%   39.41%   -1.08%     
==========================================
  Files         145      146       +1     
  Lines        4638     4775     +137     
  Branches     1087     1138      +51     
==========================================
+ Hits         1878     1882       +4     
- Misses       2746     2879     +133     
  Partials       14       14              

Flag	Coverage Δ
client	39.41% <10.00%> (-1.08%)	⬇️
server	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sjd78]

The typeahead isn't working quite right with the search string. Looks like the search string can disappear but still be applied:

screencast-localhost_9000-2023.11.20-14_14_42.webm

[sjd78]

Should the SimpleSelectTypeahead actually be contained within the above TextContent to match the location of the previous SimpleSelect?

[sjd78]

... Nope. If the new component is inside the TextContent, the drop down menu renders weird:

outside of the TextContent it is fine.

[gitdallas]

Yep, this is related to my comment at the top of this PR

[sjd78]

The typeahead filter is now working as expect.

There is one minor annoyance now. When blurring, the filter gets cleared, the select menu gets re-rendered to show all values and then it closes:

screencast-localhost_9000-2023.11.20-15_16_40.webm

Any way to close the menu and then reset the filter so the menu doesn't flash all values before closing?

[gitdallas]

interesting... i don't have it running to test and have been rolled onto another project for now. i'll see if i can look tomorrow.. maybe just clearing on open will be good instead... hopefully don't need to resort to setTimeout

[ibolton336]

Looks good! Thanks @gitdallas

[sjd78]

Latest change makes the dropdown much better behaved.