Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Regroup the dependencies table on name only, version/sha shown in details #1536

Merged
merged 2 commits into from
Nov 15, 2023
Merged

✨ Regroup the dependencies table on name only, version/sha shown in details #1536

merged 2 commits into from
Nov 15, 2023

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Nov 13, 2023 •
edited
Loading

Resolves: #1338
Resolves: https://issues.redhat.com/browse/MTA-1585

Depends on hub change konveyor/tackle2-hub#557 / konveyor/tackle2-hub#558.

Summary of changes:

  • The dependency table will show a single row for every named dependency.
  • Multiple versions will be aggregated as a single row.
  • Details about multiple versions will be available in the details drawer.
  • The details view application table will show the application + version, allowing for all versions used to be listed.

Screencap:

screencast-localhost_9000-2023.11.15-14_25_31.mp4

@sjd78 sjd78 requested a review from ibolton336 November 13, 2023 16:03
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44e6eeb) 40.46% compared to head (999e590) 40.46%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1536   +/-   ##
=======================================
  Coverage   40.46%   40.46%           
=======================================
  Files         145      145           
  Lines        4636     4636           
  Branches     1088     1088           
=======================================
  Hits         1876     1876           
  Misses       2746     2746           
  Partials       14       14
Flag Coverage Δ
client 40.46% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd78 sjd78 marked this pull request as draft November 13, 2023 18:49
@sjd78
Copy link
Member Author

sjd78 commented Nov 13, 2023

PROBLEM: The dependency data being returned will have a record for each dependency name+sha combo. Therefore, additional changes need to be made so the sha/version is only dealt with in the dependency drawer. Without a change, if multiple versions of a dependency exist, it will be shown with 2 identical looking rows.

@sjd78 sjd78 mentioned this pull request Nov 14, 2023
Merged
@sjd78
Copy link
Member Author

sjd78 commented Nov 15, 2023

PROBLEM: The dependency data being returned will have a record for each dependency name+sha combo. Therefore, additional changes need to be made so the sha/version is only dealt with in the dependency drawer. Without a change, if multiple versions of a dependency exist, it will be shown with 2 identical looking rows.

This is resolved with konveyor/tackle2-hub#557 and changes to the data/UI flow.

@ibolton336
Copy link
Member

This also resolves https://issues.redhat.com/browse/MTA-1585

sjd78 added 2 commits November 15, 2023 13:52
@sjd78
Remove Version and SHA columns from main dependencies tables
9f9652e 
Resolves: konveyor#1338

The version and sha filters, column headers and columns have been
removed.  Those two fields are not relevant in this table.  The
table does not need those details.

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78
Update models.ts fields and Dependency/App table query filter
999e590 
Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 changed the title 🐛 Remove Version and SHA columns from main dependencies tables ✨ Regroup the dependencies table on name only, version/sha shown in details Nov 15, 2023
@sjd78 sjd78 marked this pull request as ready for review November 15, 2023 19:21
@sjd78 sjd78 mentioned this pull request Nov 15, 2023
Merged
@sjd78 sjd78 requested a review from ibolton336 November 15, 2023 19:30
@sjd78
Copy link
Member Author

sjd78 commented Nov 15, 2023 •
edited
Loading

Merging blocked waiting on hub for konveyor/tackle2-hub#558

@sjd78 sjd78 merged commit 06d6551 into konveyor:main Nov 15, 2023
10 checks passed
@sjd78 sjd78 deleted the remove_columns branch November 15, 2023 20:51
ibolton336 added a commit that referenced this pull request Nov 15, 2023
@sjd78 @ibolton336
🐛 Render dependency versions as links (#1540)
2500fbc 
Resolves: #1340

On the Dependencies page, detail drawer, applications table: render the
version text as a link to the maven central repository. The link uses
the dependency's sha as the key in the maven central search.

Add component `ExternalLink` to standardize rendering links outside of
the app opening in a new tab.

Note: The resolution to #1338 will require a change to the application
table's query filter and response object. This will be done in PR #1536.
See konveyor/tackle2-hub#557 for the response
object change.

Screenshot:

![image](https://github.com/konveyor/tackle2-ui/assets/3985964/50f0c144-b4fe-4ba2-a625-3c8e6ae3be6c)

---------

Signed-off-by: Scott J Dickerson <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
This was referenced Nov 22, 2023
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibolton336 ibolton336 Awaiting requested review from ibolton336 ibolton336 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove columns from the main table in Dependencies view
2 participants
@sjd78 @ibolton336