Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update archetype tags labels to use category color #1551

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

ibolton336
Copy link
Member

https://issues.redhat.com/browse/MTA-1687 - Removes color until we can persist the color for tags on the backend.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e4ae05) 40.49% compared to head (734df37) 40.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1551   +/-   ##
=======================================
  Coverage   40.49%   40.49%           
=======================================
  Files         145      145           
  Lines        4638     4638           
  Branches     1087     1087           
=======================================
  Hits         1878     1878           
  Misses       2746     2746           
  Partials       14       14           
Flag Coverage Δ
client 40.49% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 marked this pull request as draft November 16, 2023 15:36
@ibolton336
Copy link
Member Author

Need to do something similar to what was done in the application-tags component here.

@ibolton336 ibolton336 marked this pull request as ready for review November 16, 2023 21:43
@ibolton336 ibolton336 changed the title 🐛 Remove color from labels with no backend color assigned 🐛 Update archetype tags labels to use category color Nov 16, 2023
@ibolton336 ibolton336 merged commit d215b73 into konveyor:main Nov 20, 2023
6 checks passed
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one preference on the relative import

@@ -28,7 +28,7 @@ import {
} from "@app/components/FilterToolbar";
import { useLegacyFilterState } from "@app/hooks/useLegacyFilterState";
import { useHistory } from "react-router-dom";
import { ApplicationTagLabel } from "./application-tag-label";
import { ItemTagLabel } from "../../../../components/labels/item-tag-label/item-tag-label";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use the "@app/ style

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants