-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update archetype tags labels to use category color #1551
Conversation
Signed-off-by: ibolton336 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
=======================================
Coverage 40.49% 40.49%
=======================================
Files 145 145
Lines 4638 4638
Branches 1087 1087
=======================================
Hits 1878 1878
Misses 2746 2746
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Need to do something similar to what was done in the application-tags component here. |
Signed-off-by: ibolton336 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the one preference on the relative import
@@ -28,7 +28,7 @@ import { | |||
} from "@app/components/FilterToolbar"; | |||
import { useLegacyFilterState } from "@app/hooks/useLegacyFilterState"; | |||
import { useHistory } from "react-router-dom"; | |||
import { ApplicationTagLabel } from "./application-tag-label"; | |||
import { ItemTagLabel } from "../../../../components/labels/item-tag-label/item-tag-label"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use the "@app/
style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I missed this.
https://issues.redhat.com/browse/MTA-1687 - Removes color until we can persist the color for tags on the backend.