👻 Refactor archetype table app column text #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the archetype table, applications column, update the translation key used to be plural aware via i18next: - When `count == 1`, use key `archetypeApplicationCount` - When `count != 1`, use key `archetypeApplicationCount_plural` Net result is "1 application" and "3 applications" will be rendered. The "(s)" suffix is no longer required. Note: The app is currently using `i18next` v19. In current versions, and therefore current docs, the count suffixes are different. Signed-off-by: Scott J Dickerson <[email protected]>
|
Screenshot: |
ibolton336
approved these changes
Nov 16, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
=======================================
Coverage 40.49% 40.49%
=======================================
Files 145 145
Lines 4638 4638
Branches 1087 1087
=======================================
Hits 1878 1878
Misses 2746 2746
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the archetype table, applications column, update the translation key used to be plural aware via i18next:
count == 1, use keyarchetypeApplicationCountcount != 1, use keyarchetypeApplicationCount_pluralNet result is "1 application" and "3 applications" will be rendered. The "(s)" suffix is no longer required.
Note: The app is currently using
i18nextv19. In current versions, and therefore current docs, the count suffixes are different.